Fix streaming failing with "range not supported" on servers negotiating compression - #864
Draft
mickael-menu wants to merge 1 commit into
Draft
Fix streaming failing with "range not supported" on servers negotiating compression#864mickael-menu wants to merge 1 commit into
mickael-menu wants to merge 1 commit into
Conversation
…ompression Fixes #653. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stevenzeck
reviewed
Aug 10, 2026
| // Requesting the identity encoding ensures the server advertises and | ||
| // serves byte ranges properly. | ||
| // See https://github.com/readium/swift-toolkit/issues/653 | ||
| if request.hasHeader("Range"), !request.hasHeader("Accept-Encoding") { |
Contributor
There was a problem hiding this comment.
Nothing wrong, might be better if this was in HTTPRequest as a mutating function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653.
URLSessiontransparently negotiates compressed responses (gzip/deflate/br), but servers usually cannot serve byte ranges of a compressed representation and omitAccept-Rangesin that case.DefaultHTTPClientthen misinterpreted the 200 response as the server not supporting byte ranges and failed withHTTPError.rangeNotSupported, breaking streamed publications (e.g. from the Readium publication server).DefaultHTTPClientnow sendsAccept-Encoding: identitywith any byte range request that doesn't already specify anAccept-Encoding, ensuring the server advertises and serves ranges properly. Callers can still override the header explicitly.🤖 Generated with Claude Code