Skip to content

Fix overlapping FXL pages in landscape orientation #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Conversation

mickael-menu
Copy link
Member

Fixed

Navigator

  • #635 Fixed overlapping FXL pages in landscape orientation.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes overlapping FXL (Fixed Layout) pages in landscape orientation by improving margin calculations and viewport handling in the EPUB navigator. The key changes center around removing asymmetric horizontal margins that caused page overlap and optimizing viewport updates to prevent unnecessary recalculations.

  • Removed horizontal margin calculations that caused page overlap in landscape mode
  • Added symmetrical inset handling to keep pages centered regardless of notch asymmetry
  • Optimized viewport updates with early return conditions to prevent redundant calculations

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
Sources/Navigator/EPUB/Scripts/src/fixed-page.js Removed horizontal margin calculation and added viewport update optimization
Sources/Navigator/EPUB/EPUBFixedSpreadView.swift Added symmetric horizontal inset handling for consistent page centering
Sources/Navigator/EPUB/Assets/Static/scripts/readium-fixed-wrapper-*.js Updated minified JavaScript with viewport optimization changes
CHANGELOG.md Added changelog entry documenting the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mickael-menu mickael-menu merged commit 3bfe899 into develop Aug 18, 2025
5 checks passed
@mickael-menu mickael-menu deleted the issue/635 branch August 18, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone: Right page in spread overlaps edge of left page (epub3 FXL landscape orientation)
1 participant