Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload spread if Webview is terminated #311

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

triin-ko
Copy link
Contributor

Should fix #309

@mickael-menu
Copy link
Member

@triin-ko Something I don't understand, is why reloading the spreads when the web view is killed (terminated) fixes the issue of staying at the same location when the app is restored? Did you confirm that this fixes the issue?

@triin-ko
Copy link
Contributor Author

@mickael-menu when the webViewWebContentProcessDidTerminate is called, then the webview reloads automatically to its initial location. So reloading the spreads restores the latest location

@mickael-menu
Copy link
Member

I see, apparently it is called when the app goes back into the foreground after the web view was killed. That's what got me confused.

@mickael-menu mickael-menu temporarily deployed to LCP June 26, 2023 07:41 — with GitHub Actions Inactive
@mickael-menu mickael-menu temporarily deployed to LCP June 26, 2023 07:41 — with GitHub Actions Inactive
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @triin-ko

@mickael-menu mickael-menu merged commit f47fafa into readium:develop Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants