Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] EditingActions like Define Lookup are not shown. #428

Closed
kevinzhow opened this issue May 19, 2024 · 1 comment
Closed

[Bug] EditingActions like Define Lookup are not shown. #428

kevinzhow opened this issue May 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kevinzhow
Copy link

kevinzhow commented May 19, 2024 •
edited
Loading

Describe the bug

Tested with the TestApp on develop branch and 2.7.1 tag, Define and Lookup are not shown, And if you click on the share, App will crash.
IMG_6441

How to reproduce?

1.Clone the repo
2.cd TestApp
3.make spm
4.Import a book and long press the text

Readium version

2.7.1-3.0.0-alpha.1

OS version

iOS 17.4-17.5

Testing device

iPhone 13 Pro Max

Environment

macOS: 14.5
platform: arm64
Xcode 15.4
Build version 15F31d

Additional context

No response
@kevinzhow kevinzhow added bug Something isn't working triage Triage needed by maintainers labels May 19, 2024
@mickael-menu mickael-menu removed the triage Triage needed by maintainers label Jun 4, 2024
@mickael-menu mickael-menu mentioned this issue Jun 4, 2024
Merged
@mickael-menu
Copy link
Member

Thank you for reporting this issue, I fixed it in #447. I will publish a new 2.7.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinzhow @mickael-menu