Conversation
We keep all voices but novelty and low quality by default, all voices params are now optional so that the methods can be dual purpose – with src being all parsed voices in memory, and src being arbitrary. Move duplicate removal in filter method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses ChromeOS-specific issues: deduplicating of voices, ordering of voices based on JSON quality order. It also introduces a new debug page for dev convenience, whose purpose is to mock ChromeOS
speechSynthesisso that you do not necessarily need a device running it to debug Voice management.Note this redesigns how ReadiumSpeechVoices are handled internally by the
Managerinstance, as it will keep all parsed voices in memory. You can use a filtered array and pass it to each method if you do not need to filter, sort, or group all of them. This has the unfortunate side effect of requiring further work for code-splitting tho, which will be addressed in another PR.