This repository was archived by the owner on May 7, 2025. It is now read-only.
fix IE's script70 error #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we scroll Readium tries to find the next visible media overlay element to play. The problem arises when the user changed the page and had scrolled before. Some funny combination of things triggers the scroll handler to run again and because it has a stale reference of the iframe's document IE gives out with the `script70` error message. This commit unbinds the scroll handler before that can even happen, i.e., when we are about to open a new page and rebinds it once its done. May fix readium#162.
|
@nbeach, this might sort out readium/readium-js-viewer#295, would you mind giving it a go? |
|
@dariocravero |
|
Good stuff, let me know how it goes. On Mon, Oct 5, 2015 at 5:03 PM Juan Corona notifications@github.com wrote:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we scroll Readium tries to find the next visible media
overlay element to play.
The problem arises when the user changed the page and had scrolled
before. Some funny combination of things triggers the scroll handler to
run again and because it has a stale reference of the iframe's document
IE gives out with the
script70error message.This commit unbinds the scroll handler before that can even happen,
i.e., when we are about to open a new page and rebinds it once its done.
May fix #162.