Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese RTL vertical writing mode, page selection based on rectangle visibility trailing instead of leading "edge" (CfiNavigationLogic) #114

Open
danielweck opened this issue Sep 9, 2014 · 1 comment

Comments

@danielweck
Copy link
Member

See:
#87
#113

When an element (e.g. a run of text) spans across two (or more) consecutive "pages" (a "page" is effectively a CSS column, which ; in vertical writing mode ; always fills the entire iframe viewport, as there is no two-page synthetic spread), such element is considered "visible" based on the visibility of the trailing text (i.e. bottom-left corner of the bounding box / client rectangles). This results in the last page being selected, instead of the first. In other word, when hyperlinking to an element that spans from one page to another, the algorithm should bring to view the "leading edge" (e.g. beginning of a sentence), i.e. the top-right corner of the bounding box / client rectangles. You can test this behaviour by playing the Media Overlays of Kusamakura (chapters 1,2,3), and by using the previous/next buttons in the MO control panel to transition from one page to the next (forwards from right to left, then backwards).

EPUB:
https://code.google.com/p/epub-samples/downloads/detail?name=kusamakura-japanese-vertical-writing-20121124.epub

@danielweck danielweck added this to the v1+ milestone Sep 9, 2014
@rkwright rkwright modified the milestones: m1.2, m1.1 Oct 24, 2014
@danielweck danielweck added the CFI label May 27, 2015
jccr pushed a commit that referenced this issue Sep 16, 2015
jccr pushed a commit that referenced this issue Oct 1, 2015
jccr pushed a commit that referenced this issue Oct 1, 2015
@danielweck
Copy link
Member Author

Is that fixed by Juan's PR? ( @jccr )
#210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants