Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorium ports #145

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Thorium ports #145

merged 10 commits into from
Aug 27, 2024

Conversation

JayPanoz
Copy link
Collaborator

Please check if the PR fulfills these requirements:

(Add x between brackets to check.)

  • I’ve read contributing guidelines
  • I’m making this pull request against the develop branch
  • I’ve updated from the develop branch before proposing this pull request
  • I’ve tested the changes for bug fixes and/or features
  • I’ve documented new code

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)

This PR implement Thorium changes that can be useful to all consumers of ReadiumCSS.

Specifically:

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

It should only introduce fixes and new user settings. That said the situation may be slightly different for Thorium and other apps having handled #94 and #128, given the fixes and features are already implemented in another way.

Otherwise, it’s 2 extra user settings to implement:

  • letter-spacing in CJK
  • hiding ruby annotation using a new flag --USER__no-ruby: readium-noRuby-on (part of settings requiring the advanced flag).

Other information:

I guess @danielweck would be the best one to check/review this PR, considering his changes are ported into ReadiumCSS as a whole.

But any feedback welcome, especially on hiding ruby annotation cos’ naming things is hard, and perhaps we don’t want to tie it to advanced settings, it should just be its own thing with no other flag required.

Audio now on its own so that value auto for width or height doesn’t break controls. Resolves #94
Forcing value of var instead of inherit to make sure it is applied in all conditions. Resolves #128
This module allows for the hiding of ruby annotations in CJK. Resolves #140
Tests for letter-spacing in CJK and hiding ruby annotations
@JayPanoz JayPanoz requested a review from danielweck July 31, 2024 15:36
@JayPanoz
Copy link
Collaborator Author

@danielweck does this look good to you?

As a reminder, this will be tagged as the last of version 1 in the main branch in order to push version 2 on develop.

@JayPanoz JayPanoz removed the request for review from danielweck August 27, 2024 14:04
@JayPanoz
Copy link
Collaborator Author

Note: In order to progress on v2, and make it available for testing ASAP, it’s been discussed we pull these changes into develop and postpone the review to develop → master.

As a reminder, once pulled in master, this will be tagged as the last version 1. Work on version 2 will then be carried into develop.

@JayPanoz JayPanoz merged commit 754a177 into develop Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant