Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
(Add x between brackets to check.)
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
This PR implement Thorium changes that can be useful to all consumers of ReadiumCSS.
Specifically:
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It should only introduce fixes and new user settings. That said the situation may be slightly different for Thorium and other apps having handled #94 and #128, given the fixes and features are already implemented in another way.
Otherwise, it’s 2 extra user settings to implement:
--USER__no-ruby: readium-noRuby-on
(part of settings requiring the advanced flag).Other information:
I guess @danielweck would be the best one to check/review this PR, considering his changes are ported into ReadiumCSS as a whole.
But any feedback welcome, especially on hiding ruby annotation cos’ naming things is hard, and perhaps we don’t want to tie it to advanced settings, it should just be its own thing with no other flag required.