This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Add the Publication's positionList #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolling88
reviewed
Feb 11, 2020
| override fun locationDidChange(navigator: Navigator?, locator: Locator) { | ||
| Timber.d("locationDidChange position ${locator.locations.position ?: 0}/${publication.positionList.size} $locator") |
There was a problem hiding this comment.
Since the last position could contain several screen pages, it would be helpful with an event that notifies when we reach the end of the book.
There was a problem hiding this comment.
I opened an issue for that: readium/architecture#115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentLocation.currentLocationshould not be overriden in the testapp.Locatormodel.Bookmark,Highlight), see these changes:BookmarkHighlightSearchLocatorand useLocatordirectly instead