Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Fix compile error #139

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix compile error #139

merged 1 commit into from
May 26, 2021

Conversation

ettore
Copy link
Contributor

@ettore ettore commented May 26, 2021

Reported by Xcode 12.4: "Variable used within its own initial value"

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn it, right after the release :/

Makes me think that it could make sense to have different patch versions on each repo but keep major and minor versions synchronized.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ettore Could you apply this patch to update the changelog? Thanks

changelog.patch

"Variable used within its own initial value"
@ettore
Copy link
Contributor Author

ettore commented May 26, 2021

Damn it, right after the release :/

Makes me think that it could make sense to have different patch versions on each repo but keep major and minor versions synchronized.

that makes total sense to me. The patch updates are per semantic versioning just fixing bugs, so it will just make for a more agile development process i.e. more frequent individual bugfix releases. And of course being able to bind to an actual version in carthage (or other dependency systems) is much better than running at the top of develop.

@mickael-menu mickael-menu merged commit 9fc2bc0 into readium:develop May 26, 2021
@mickael-menu
Copy link
Member

@ettore I'll do a release this Friday if no other bugs surface

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants