This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Kotlin and Gradle updates #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenzeck
commented
Jun 26, 2021
stevenzeck
commented
- Updated the Kotlin version
- Updated Gradle
- Updated dependencies
- Replaced deprecated code
mickael-menu
approved these changes
Jul 1, 2021
Comment on lines
+120
to
+121
| //TODO Figure out a better way to handle this Kotlin warning | ||
| tryOrLog<Nothing> { |
There was a problem hiding this comment.
To add some context, 1.5 added a new warning in this case, when the type inference is ambiguous: https://youtrack.jetbrains.com/issue/KT-36776
| @@ -164,6 +162,8 @@ class Publication( | |||
| /** | |||
| * Closes any opened resource associated with the [Publication], including services. | |||
| */ | |||
| @DelicateCoroutinesApi | |||
| //TODO Change this to be a suspend function | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.