Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

adding hyphenations option & fix NaN value when the window is hidden #76

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

ehapmgs
Copy link
Contributor

@ehapmgs ehapmgs commented Aug 6, 2019

1- adding a switchable hyphenation option
2- If the Webview is hidden scrollWidth or scrollHeight will equal zero, JS will return NaN value to swift causing it to crash

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehapmgs Thanks for this useful addition 👍

@mickael-menu mickael-menu merged commit 6654a5d into readium:develop Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants