Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Add ability to configure UserSettings default values #191

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

ettore
Copy link
Contributor

@ettore ettore commented Jul 16, 2021

This allows apps to be able to set their own initial values for every UserProperty.

@ettore
Copy link
Contributor Author

ettore commented Jul 16, 2021

This should be a non-breaking change because the existing values are preserved, and the api signatures are compatible with the previous ones via default param values.

The documentation mentions "removing objects from userProperties", which is something made possible by the related r2-shared PR: readium/r2-shared-swift#157.

The documentation for pageMargins and lineHeight lacks the unit of measure but I wasn't sure which one (px, pt, em, etc) ReadiumCSS is using.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I just moved the userSettings param to the EPUBNavigatorViewController.Configuration object, instead of the navigator initializer.

@mickael-menu mickael-menu merged commit e469b7d into readium:develop Jul 19, 2021
@ettore ettore deleted the support/usersettings-config branch August 5, 2021 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants