Preferences api migration #64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMP until the ts-toolkit branch is merged and we can migrate to the npm package
Beware: super buggy ATM
Deploying playground with
|
| Latest commit: |
dc10643
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf0aee69.playground-7xz.pages.dev |
| Branch Preview URL: | https://preferencesapi-migration.playground-7xz.pages.dev |
That was tied to the container’s width + arrows placement, and not used any longer as the container’s sizing is now the responsibility of the ts-toolkit.
Should snapCurrentOffset a little bit better
Error popped up out of nowhere today.
Hopefully this should fix remaining issues on touch devices, which were side effects of the previous resolutions
Instead of relying on useEffect in Reader
In theory, it should also work for FXL, with useEpubNavigator providing what’s needed for FXL or reflow.
With known line-height bug in ReadiumCSS: readium/readium-css#166
React Aria Components have now Tree out of unstable
There’s still a massive margin-left and -right applied to body for no apparent reason cos’ the resizeHandler should take care of that and resize the container accordingly…
So that we can test/debug canvas measureText
TODO: zoom < 1
Exposing PaginationStrategies to make it testable and confirm it’s implementing the logic properly.
Not implemented
+ TMP component for testing purposes
Resolves #67
No longer necessary thanks to fix on scroller
Instead of absolute
And move RSPaginationStrategy to Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate user settings to the Preferences API in ts-toolkit. This will end up in a lot of complexity being removed from the codebase, and handled directly by
EpubNavigator.In practice, this means:
At the time of drafting, this migration to the Preferences API is done in a relatively simplistic way in order to remove the major part of the complexity we’re aiming to remove. Things will evolve as we implement new settings and resolve side-effects.