Add experimental EPUB decoration positioning #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will position decorations between text and background, allowing for opaque highlight colors
mickael-menu
changed the title
Member
|
@ddfreiling Would you mind applying this patch to your PR? For some reason I cannot push on your repo even though you enabled edits from maintainers. Thank you! |
Contributor
Author
Applied the patch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option for EpubNavigator to position default decorations between text and background, allowing for opaque highlight colors.
See swift-toolkit equivalent PR:
readium/swift-toolkit#665
Without experimental positioning:
(notice that highlight affects text color and gives a "blurry" feel.
With experimental positioning:
(here highlight is also opaque with alpha = 1.0)