-
Notifications
You must be signed in to change notification settings - Fork 32
Swift 6.2 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Swift 6.2 #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Clang Snapshot Path Mismatch
The script hardcodes a specific snapshot date in the toolchain path for accessing clang. This conflicts with swiftly install 6.2-snapshot, which installs the latest available snapshot with a dynamic date. Consequently, the hardcoded directory does not exist, causing the pushd command and clang version check to fail. The toolchain name should be dynamically determined, consistent with SWIFT_PATH export.
build/020-clone-swift.sh#L55-L61
swift-android-toolchain/build/020-clone-swift.sh
Lines 55 to 61 in 7092eda
| swiftly install 6.2-snapshot | |
| swiftly use 6.2-snapshot | |
| pushd .local/share/swiftly/toolchains/6.2-snapshot-2025-07-04/usr/bin/ | |
| ./clang --version | |
| popd |
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
🕵️ Potential Secrets Leak Detected!
1 security issue(s) found.
Gitleaks scan detected potential secrets or sensitive data in your code.
This may violate our Security Code Requirements Policy and raise serious security risks.
Please review and fix these findings before merging this pull request.
Tip
If you are confident that a finding is a false positive (e.g., related to test data or non-sensitive sample values) consider Ignoring but do that with an extreme caution only after reliable review and verification.
You can use provided suppression line to put into .gitleaksignore or use #gitleaks: accept comment in code. Please add comments to explain finding suppression to make this decision clear.
📄 Dockerfile
📍 Location: Line 52 / Commit: e0cfa1c
❗ Issue: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
# clearly explain why this is safe to ignore!
Dockerfile:generic-api-key:52Important
🛡️ Required Actions
- Remove any secrets or sensitive data from your code and commit history
- Rotate any exposed credentials immediately
- Use environment variables or a secure secret management solution instead of hardcoding
- Contact @devsecops team for guidance if you’re unsure about a finding.
🤖 This review was automatically generated by the Readdle Gitleaks GitHub App
cfea8e5 to
3a835ef
Compare
3a835ef to
27303cf
Compare
a82144a to
2a8fd8c
Compare
2a8fd8c to
e2369e7
Compare
846133b to
ee08995
Compare
02e4c5f to
1a1b026
Compare
1a1b026 to
9c5a54e
Compare
Note
Upgrade to Swift 6.2 with Swiftly-based bootstrap, refresh build dependencies, adjust Android presets, and remove several custom patches.
6.2and updatebuild/versionto6.2-r1.swiftly(install/use6.2-snapshot; exportSWIFT_PATH).build/000-install-dependencies-nobel.shand addjqfor Swiftly.patches/swift/0001-Add-presets-for-android-x86-x86_64.patchwithpatches/swift/0001-Add-presets-for-android-x86.patch(adds x86 preset; x86_64 handled upstream).patches/swift-corelibs-foundation/0011-fix-parsing-tzdata-version-2-plus.patchpatches/swift-corelibs-foundation/0014-add-swift-syntax-source-dir-variable.patchpatches/swift-corelibs-foundation/0015-add-empty-CFPosixSpawnFileActionsChdir-for-android.patchpatches/swift-foundation/0001-open-range-attributed-string-from-nsrange.patchpatches/swift-syntax/0001-replace-bionic-with-android.patchWritten by Cursor Bugbot for commit 8f0d496. This will update automatically on new commits. Configure here.