Skip to content

[0.75] Fix Symlinks in Hermes #461

Closed
@cipolleschi

Description

@cipolleschi

Target Branch(es)

0.75

Link to commit or PR to be picked

facebook/react-native#46301

Description

When building hermes on GH actions, we store the iOS slices as artifacts using the GHA upload-artifacts action.
When uploading a folder, the upload-artifacts action follow the symlinks and copies and pastes the content of the links instead of preserving the Symlink itself.
This breaks the xcframework for macOS and catalyst.

We fixed this by compressing the folder and then uploading the tarball instead of the original folder.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type Pick RequestPick requests to include commits inside a React Native release

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions