-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropdownMenu - positionFixed not working anymore since v8 #1473
Closed
Maczuga opened this issue
Apr 26, 2019
· 2 comments
· Fixed by #1538 · May be fixed by largerock/largerock.com#5
Closed
DropdownMenu - positionFixed not working anymore since v8 #1473
Maczuga opened this issue
Apr 26, 2019
· 2 comments
· Fixed by #1538 · May be fixed by largerock/largerock.com#5
Comments
ccummings
added a commit
to ccummings/reactstrap
that referenced
this issue
Jun 13, 2019
Allow the positionFixed prop to be passed through to the Popper component Fixes reactstrap#1473
ccummings
added a commit
to ccummings/reactstrap
that referenced
this issue
Jun 13, 2019
Allow the positionFixed prop to be passed through to the Popper component Fixes reactstrap#1473
12 tasks
TheSharpieOne
pushed a commit
that referenced
this issue
Jul 9, 2019
Allow the positionFixed prop to be passed through to the Popper component Fixes #1473
This still isn't working for me in 8.1.1, though I'm not sure I see why :( Reverted to 7.1.0 and positionFixed works as expected. |
Nevermind it works just fine, I was accidentally overriding the DropdownMenu style, which negated any additional style attribute being set by popper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DropdownMenu
#8.0.0
umd/csj/es
#16.8.4
#4.3.1
What is happening?
Before v8 we used to be able to pass "positionFixed" prop in DropdownMenu component, which would be passed down to popper.
Since this commit this is no longer a case: 1afb2c2#comments
Due to that - it is impossible to use react-popper to make dropdown menu fixed instead of absolute.
More info about positionFixed in DropdownMenu: #1098 (comment)
What should be happening?
positionFixed prop (and perhaps some more) should be able to go into Popper.
Steps to reproduce issue
Error message in console
none
Code
<DropdownMenu modifiers={{preventOverflow: {boundariesElement: 'window'}}} positionFixed={true}>{options}</DropdownMenu>
The text was updated successfully, but these errors were encountered: