Skip to content

Fix: children not rerendering #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

kopax
Copy link
Contributor

@kopax kopax commented Feb 8, 2021

Fix #22 #37 #50 #51

@kopax
Copy link
Contributor Author

kopax commented Feb 8, 2021

I am using it with path-packge and it work. Perhaps to avoid breaking change due to hack in user land code, we should allow to disable the feature with uniqueChildrenRender={true} ?

@oxyii oxyii requested a review from jarvisluong February 8, 2021 16:29
@oxyii
Copy link
Collaborator

oxyii commented Feb 8, 2021

@kopax thank you! Let me know if @jarvisluong will not review in few days

@jarvisluong
Copy link
Contributor

Looks good! Thanks for your contribution!

p/s: About the breaking change, we can release it as a minor version bump

@jarvisluong jarvisluong merged commit 81287d0 into reactrondev:master Feb 8, 2021
@kopax
Copy link
Contributor Author

kopax commented Feb 8, 2021

@jarvisluong, If people were relying on the not rerendering behavior, then it may break their app. Since this was not a feature and this kind of integration would be incorrect, I don't think we can call it a breaking change.

Would you guys mind to publish a new version so I can get rid of the patch package?

@kopax kopax deleted the patch-1 branch February 8, 2021 20:50
@kopax
Copy link
Contributor Author

kopax commented Feb 8, 2021

Also, doc should now warn users that the el will now include props.activeIndex and props.index. If you guys wonder why I choose to use -1 when activeIndex - index = 0, it's for forcing a rerendering of the view when it become active.

@kopax
Copy link
Contributor Author

kopax commented Feb 9, 2021

@jarvisluong I opened #58 to improve the documentation.

I am encountering a new kind of issue while re-rendering on an iPhone 6, within my slides I have one LottieAnimation and one Animatable.View (which fadein/out a button) per slide which may be RAM consuming animations. It seems that the re-rendering of the active slide causes a visible display lag.

This bug is possible since we allowed to re-render the active slide while displaying it. I may work on solving the issue but any feedback on how to improve this would be appreciated.

@jarredt jarredt mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerender swiper
3 participants