-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Play]: Savings Calculator #748
Conversation
@kd100100 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
@Sachin-chaurasiya @koustov @atapas Could you please review this? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial changes.
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
@Sachin-chaurasiya I have made the changes. Could you please review? |
@Sachin-chaurasiya Is it possible to re-review and suggest changes by this month end, so that it can be considered as an hactoberfest contribution once merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few final changes.
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
src/plays/savings-calculator/components/SavingOptions/index.jsx
Outdated
Show resolved
Hide resolved
@kd100100 , Left a few comments. |
@Sachin-chaurasiya Made the changes! Please re-review! |
Great work @kd100100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
Description
A simple savings calculator where one can enter starting balance, monthly contribution, period/tenure and annual interest rate to get the end balance after the period/tenure..
Fixes #746
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested in local environment in cypress. Added unit tests using jest to confirm functionalities are working.
Checklist: