-
-
Notifications
You must be signed in to change notification settings - Fork 935
fix: Ensure header button border remain visible on mobile hover/focus #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
Module not found: Error: Can't resolve './components/HomePage' in '/opt/build/repo/src/plays/zoomlogin' @Rohs21 please check |
|
Hey @priyankarpal can you please help me with this because you can see the file changes is only about the 2 line of css change in the header.css so why the deployment is crashing for this PR? |
let me check |
|
|
@priyankarpal any update on this? |
I will merge this PR once issue #1607 is merged |
|
Okay @priyankarpal thanks for the update |
priyankarpal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
Thankyou so much @priyankarpal !! |
|
@Rohs21 can you share your linkedin profile here. Also please share merged pr to social & tag react play. |
|
Sure @priyankarpal ! 😊 And here’s the post about my PR: x.com/rohansingh2104/status/1975461824947757370?s=61 |
Thanks |
Fixes #1596 : Ensure header button icons remain visible on mobile hover/focus
Problem
In mobile view, the icons inside the header buttons (Browse and Events) were disappearing when hovered or focused. This issue did not occur in desktop view, where the icons behaved as expected. The problem was caused by CSS rules that altered the fill, opacity, or visibility of the icons on hover/focus, combined with mobile-specific styles.
Solution
The CSS for .app-header-btn was updated with border color = "#00f2fe" to ensure the buttons remain visible and properly styled on hover/focus in mobile view.
Changes Made
Added a mobile-specific CSS rule to ensure the icons inside .app-header-btn remain visible with the border color "#00f2fe" on hover/focus.
Ensured the display, width, height, opacity, visibility, and fill properties of the icons are correctly set for mobile view.
Before and After
Before: buttons disappear on hover/focus in mobile view.

After: buttons border remain visible and styled correctly on hover/focus in mobile view.
