Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Request: New Play - BMI Calculator #1549

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

Adil-Khan-N
Copy link
Contributor

Fixes #1524

I’m excited to submit my merge request for the new BMI Calculator play! 🎈 This feature enhances our project by providing users with a simple and effective tool to calculate their Body Mass Index, making health and fitness tracking more accessible.

I would greatly appreciate it if you could review and accept this merge request, tagging it with the Hacktoberfest label. Your support means a lot to me!

Thank you for your time and consideration! 🙏

image

image

image

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit d7632fe
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/670d11d7b982fd000893516e
😎 Deploy Preview https://deploy-preview-1549--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal
Copy link
Member

@Adil-Khan-N please use different class names for the project. Also, the bg image is not rendering

Screenshot_2024-10-12_09-00-23

@priyankarpal priyankarpal added the changes required need to change some thing label Oct 12, 2024
@Adil-Khan-N
Copy link
Contributor Author

I have changed the class names, but still the image is not rendering.

I have added a cover.jpg file in my play directory and also mentioned the name in the edit page of game, still it is not rendering, Could you please guide on what to give in the image URL section of the edit page.

image

@priyankarpal
Copy link
Member

I have changed the class names, but still the image is not rendering.

I have added a cover.jpg file in my play directory and also mentioned the name in the edit page of game, still it is not rendering, Could you please guide on what to give in the image URL section of the edit page.

image

for now merging this pr will check the cover image later.

@priyankarpal priyankarpal merged commit 765da4c into reactplay:main Oct 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required need to change some thing hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add more play ideas
2 participants