-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: play cards ui #1461
fix: play cards ui #1461
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
Signed-off-by: Akshay Gore <92959398+Akshaygore1@users.noreply.github.com>
also please check this image too @Akshaygore1 |
I have updated the request as per your instructions regarding the changes. @priyankarpal |
there is a little bit issue just need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use Tailwind CSS instead of writing vanilla CSS
We could, but I didn't use it because the properties of the icon are not being overridden. |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
@Akshaygore1 I will suggest to name branches like this format fix-issue-issuenumber
@all-contributors please add @Akshaygore1 as a contributor for code |
I've put up a pull request to add @Akshaygore1! 🎉 |
Description
#1447
After taking the lead on the issue, I created a new Card component called playCard and passed props to it, resulting in a change in the UI.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
You Can go to /play route and see the changes
Checklist:
] I have performed a self-review of my own code
Screenshots or example output