Minor code style improvements to fix phpstan analysis warnings#140
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom May 23, 2019
realFlowControl:feature/phpstan
Merged
Minor code style improvements to fix phpstan analysis warnings#140WyriHaximus merged 1 commit intoreactphp:masterfrom realFlowControl:feature/phpstan
WyriHaximus merged 1 commit intoreactphp:masterfrom
realFlowControl:feature/phpstan
Conversation
clue
approved these changes
May 18, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@flow-control Changes LGTM, thanks for the update! 
clue
changed the title
jsor
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request fixes some small errors reported by phpstan. As phpstan requires PHP >= 7.1 we may not add it to composer as of now