Change default socket backlog size to 511#242
Merged
jsor merged 1 commit intoreactphp:masterfrom Aug 1, 2020
Merged
Conversation
The `backlog` parameter used to default to just 32 as of PHP 5.3.3 and used to be hard coded to 4 in earlier PHP versions. The new default of 511 was evaluated to be a reasonable value for event-driven applications that can cope with many concurrent connections on a variety of platforms. In particular, this solves common ECONNRESET (connection reset by peer) errors when running benchmarks with higher concurrency. For more specific requirements, the `backlog` parameter can be given explicitly to override this default. See php/php-src@5b277c4
WyriHaximus
approved these changes
Jul 31, 2020
Contributor
|
@clue Care to shed some light why you chose 511 instead of 512? |
Member
Author
Originally posted by @CharlotteDunois in reactphp/http#354 (comment) |
Contributor
|
Thanks! |
jsor
approved these changes
Aug 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
backlogparameter used to default to just 32 as of PHP 5.3.3 andused to be hard coded to 4 in earlier PHP versions.
The new default of 511 was evaluated to be a reasonable value for
event-driven applications that can cope with many concurrent connections
on a variety of platforms. In particular, this solves common ECONNRESET
(connection reset by peer) errors when running benchmarks with higher
concurrency. For more specific requirements, the
backlogparameter canbe given explicitly to override this default.
See php/php-src@5b277c4
Refs reactphp/http#354 and others