Fix forward compatibility with upcoming EventLoop releases in tests#125
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Oct 8, 2017
Merged
Fix forward compatibility with upcoming EventLoop releases in tests#125WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Oct 8, 2017
jsor
approved these changes
Oct 8, 2017
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small oversight from #104: The test suite still used the deprecated
tick()method which will be removed in the upcoming EventLoop release.Builds on top of #104