Run tests on PHP 7.4 and simplify test matrix #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
changed the title
|
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the It can not be reproduced when running on any other PHP version, when This means the test failure is bogus. |
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding some other test cases. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping some test case for now.
I don' want to hold this PR back due to a bogus build error, so let's work around this by temporarily skipping some test cases for now. This is similar to the work around in #428 and can be reverted once reactphp/dns#164 is released in a future version. PR is ready for review |
WyriHaximus
approved these changes
Jul 11, 2020
jsor
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of reactphp/socket#208, reactphp/dns#156, reactphp/promise-timer#41 and others.
Supersedes / closes #436