Skip to content

Simplify queue draining while retaining functionality#158

Merged
jsor merged 1 commit intoreactphp:masterfrom
WyriHaximus-secret-labs:queue-drain-simplyfied
Feb 6, 2020
Merged

Simplify queue draining while retaining functionality#158
jsor merged 1 commit intoreactphp:masterfrom
WyriHaximus-secret-labs:queue-drain-simplyfied

Conversation

@WyriHaximus
Copy link
Member

No description provided.

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way 👍

@WyriHaximus
Copy link
Member Author

LGTM either way

It's one of the things I tried out to resolve the 7.4 GC issues, didn't work out as hoped but liking how concise and simple it is now.

@jsor jsor merged commit 8d05ffd into reactphp:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants