Skip to content

[3.x] Improve PHP8.5+ support #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

[3.x] Improve PHP8.5+ support #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1555c72
[3.x] Run CI jobs on PHP8.5
WyriHaximus Nov 13, 2025
4b4c7e4
[3.x] Fix reflection setAccessible deprecation warnings
WyriHaximus Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
strategy:
matrix:
php:
- 8.5
- 8.4
- 8.3
- 8.2
Expand Down
40 changes: 30 additions & 10 deletions tests/BrowserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ public function setUpBrowser()
$this->browser = new Browser(null, $this->loop);

$ref = new \ReflectionProperty($this->browser, 'transaction');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ref->setValue($this->browser, $this->sender);
}

Expand All @@ -34,11 +36,15 @@ public function testConstructWithoutLoopAssignsLoopAutomatically()
$browser = new Browser();

$ref = new \ReflectionProperty($browser, 'transaction');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$transaction = $ref->getValue($browser);

$ref = new \ReflectionProperty($transaction, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($transaction);

$this->assertInstanceOf(LoopInterface::class, $loop);
Expand All @@ -51,23 +57,33 @@ public function testConstructWithConnectorAssignsGivenConnector()
$browser = new Browser($connector);

$ref = new \ReflectionProperty($browser, 'transaction');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$transaction = $ref->getValue($browser);

$ref = new \ReflectionProperty($transaction, 'sender');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$sender = $ref->getValue($transaction);

$ref = new \ReflectionProperty($sender, 'http');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$client = $ref->getValue($sender);

$ref = new \ReflectionProperty($client, 'connectionManager');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$connectionManager = $ref->getValue($client);

$ref = new \ReflectionProperty($connectionManager, 'connector');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$ret = $ref->getValue($connectionManager);

$this->assertSame($connector, $ret);
Expand All @@ -78,11 +94,15 @@ public function testConstructWithLoopAssignsGivenLoop()
$browser = new Browser(null, $this->loop);

$ref = new \ReflectionProperty($browser, 'transaction');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$transaction = $ref->getValue($browser);

$ref = new \ReflectionProperty($transaction, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($transaction);

$this->assertSame($this->loop, $loop);
Expand Down
64 changes: 48 additions & 16 deletions tests/HttpServerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,21 @@ public function testConstructWithoutLoopAssignsLoopAutomatically()
$http = new HttpServer(function () { });

$ref = new \ReflectionProperty($http, 'streamingServer');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$streamingServer = $ref->getValue($http);

$ref = new \ReflectionProperty($streamingServer, 'clock');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$clock = $ref->getValue($streamingServer);

$ref = new \ReflectionProperty($clock, 'loop');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$loop = $ref->getValue($clock);

$this->assertInstanceOf(LoopInterface::class, $loop);
Expand Down Expand Up @@ -331,7 +337,9 @@ public function testServerConcurrency($memory_limit, $post_max_size, $expectedCo
$http = new HttpServer(function () { });

$ref = new \ReflectionMethod($http, 'getConcurrentRequestsLimit');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$value = $ref->invoke($http, $memory_limit, $post_max_size);

Expand All @@ -343,7 +351,9 @@ public function testServerGetPostMaxSizeReturnsSizeFromGivenIniSetting()
$http = new HttpServer(function () { });

$ref = new \ReflectionMethod($http, 'getMaxRequestSize');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$value = $ref->invoke($http, '1k');

Expand All @@ -355,7 +365,9 @@ public function testServerGetPostMaxSizeReturnsSizeCappedFromGivenIniSetting()
$http = new HttpServer(function () { });

$ref = new \ReflectionMethod($http, 'getMaxRequestSize');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$value = $ref->invoke($http, '1M');

Expand All @@ -371,7 +383,9 @@ public function testServerGetPostMaxSizeFromIniIsCapped()
$http = new HttpServer(function () { });

$ref = new \ReflectionMethod($http, 'getMaxRequestSize');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$value = $ref->invoke($http);

Expand All @@ -388,17 +402,23 @@ public function testConstructServerWithUnlimitedMemoryLimitDoesNotLimitConcurren
ini_set('memory_limit', $old);

$ref = new \ReflectionProperty($http, 'streamingServer');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$streamingServer = $ref->getValue($http);

$ref = new \ReflectionProperty($streamingServer, 'callback');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middlewareRunner = $ref->getValue($streamingServer);

$ref = new \ReflectionProperty($middlewareRunner, 'middleware');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middleware = $ref->getValue($middlewareRunner);

Expand All @@ -418,17 +438,23 @@ public function testConstructServerWithMemoryLimitDoesLimitConcurrency()
ini_set('memory_limit', $old);

$ref = new \ReflectionProperty($http, 'streamingServer');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$streamingServer = $ref->getValue($http);

$ref = new \ReflectionProperty($streamingServer, 'callback');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middlewareRunner = $ref->getValue($streamingServer);

$ref = new \ReflectionProperty($middlewareRunner, 'middleware');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middleware = $ref->getValue($middlewareRunner);

Expand All @@ -441,17 +467,23 @@ public function testConstructFiltersOutConfigurationMiddlewareBefore()
$http = new HttpServer(new StreamingRequestMiddleware(), function () { });

$ref = new \ReflectionProperty($http, 'streamingServer');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$streamingServer = $ref->getValue($http);

$ref = new \ReflectionProperty($streamingServer, 'callback');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middlewareRunner = $ref->getValue($streamingServer);

$ref = new \ReflectionProperty($middlewareRunner, 'middleware');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$middleware = $ref->getValue($middlewareRunner);

Expand Down
4 changes: 3 additions & 1 deletion tests/Io/ClockTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public function testNowResetsMemoizedTimestampOnFutureTick()
$now = $clock->now();

$ref = new \ReflectionProperty($clock, 'now');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}
$this->assertEquals($now, $ref->getValue($clock));

$this->assertNotNull($tick);
Expand Down
20 changes: 15 additions & 5 deletions tests/Io/MultipartParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,15 +1049,25 @@ public function testWeOnlyParseTheAmountOfMultiPartChunksWeConfigured()

$reflectecClass = new \ReflectionClass(MultipartParser::class);
$requestProperty = $reflectecClass->getProperty('request');
$requestProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$requestProperty->setAccessible(true);
}
$cursorProperty = $reflectecClass->getProperty('cursor');
$cursorProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$cursorProperty->setAccessible(true);
}
$multipartBodyPartCountProperty = $reflectecClass->getProperty('multipartBodyPartCount');
$multipartBodyPartCountProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$multipartBodyPartCountProperty->setAccessible(true);
}
$maxMultipartBodyPartsProperty = $reflectecClass->getProperty('maxMultipartBodyParts');
$maxMultipartBodyPartsProperty->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$maxMultipartBodyPartsProperty->setAccessible(true);
}
$parseBodyMethod = $reflectecClass->getMethod('parseBody');
$parseBodyMethod->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$parseBodyMethod->setAccessible(true);
}

$this->assertSame(0, $cursorProperty->getValue($parser));

Expand Down
4 changes: 3 additions & 1 deletion tests/Io/RequestHeaderParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,9 @@ public function testServerParamsWillBeRememberedUntilConnectionIsClosed()
$connection->emit('data', ["GET /foo HTTP/1.0\r\nHost: example.com\r\n\r\n"]);

$ref = new \ReflectionProperty($parser, 'connectionParams');
$ref->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$ref->setAccessible(true);
}

$this->assertCount(1, $ref->getValue($parser));

Expand Down
Loading