Improve performance by skipping buffering empty request body#291
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Dec 30, 2017
Merged
Improve performance by skipping buffering empty request body#291WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
jsor
approved these changes
Dec 30, 2017
WyriHaximus
approved these changes
Dec 30, 2017
This was referenced Dec 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very simple PR avoids waiting for the incoming request stream to end when the request body is known to be empty. Most "normal"
GETrequests etc. do not have a request body, so this affects a significant number of requests. When running example 99 with included benchmarking instructions, this simple change improves performance from ~2000 req/s to ~2400 req/s on my local machine.