Skip to content

Added multipart support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

arunpoudel
Copy link

Added multipart support, will work on test cases after we have discussed the implementation.

@cboden
Copy link
Member

cboden commented Jan 25, 2015

As stated in this comment I don't feel multi-part handling should be tightly coupled to the filesystem, I think providing indirection to the developer to pipe to the filesystem or another socket would be better.

That is just my thought I'm open to opinions.

@WyriHaximus
Copy link
Member

I'm with @cboden on this. Using streams empowers the developer to handle the uploaded file in a desired way for the project.

@clue
Copy link
Member

clue commented Feb 10, 2017

Thanks for filing this PR @arunpoude and I really appreciate your effortl 👍

I think this addresses a real issue, but I'd rather address parsing via #105. That ticket also mentions quite a few pitfalls that I don't see being addressed in this PR.

This is kind of an old PR and it contains plenty of merge conflicts now. Unfortunately, this hasn't been updated in years, so I'll close this due to a lack of feedback. If you think this is still worth addressing, please update this PR or file a new one and we can reconsider this 👍

@clue clue closed this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants