-
-
Notifications
You must be signed in to change notification settings - Fork 132
PeclEvLoop: Add new PeclEvLoop (PECL ext-ev) #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4455a3b
Add loop driver for pecl libev extension.
markkimsal 051a4a3
Document new driver.
markkimsal 0b375f7
Replace "EvLoop::defaultLoop()" with "new EvLoop()".
ivkalita 3391da5
Fix PeclEvLoop SplObjectStorage item retrieving method.
ivkalita 0e56b44
Remove unnecessary "use" statements from PeclEvLoop.
ivkalita 316e6a9
Remove nextTickQueue from PeclEvLoop.
ivkalita 4c70da0
Rename PeclEvLoop private members in StreamSelectLoop way.
ivkalita 3ae1829
Prevent PeclEvLoop from updating existing streams callbacks.
ivkalita 52e5e2e
Add early returns in PeclEvLoop removeReadStream, removeWriteStream a…
ivkalita 5392032
Make PeclEvLoop::run more verbose.
ivkalita 45b7ab0
Add PeclEvLoop::__destruct() to prevent SEGFAULT.
ivkalita 42bc95d
Remove unnecessary PeclEvLoop::tick().
ivkalita dac7c41
Remove unnecessary "@inheritdoc" from PeclEvLoop.
ivkalita 41d9d63
Add base test for canceling non-existent timer.
ivkalita 2ef8ff0
Add PeclEvLoop test.
ivkalita 54710a3
Add PeclEvLoopTimerTest.
ivkalita 79dd25c
Add PECL ev extension to travis-init.sh.
ivkalita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,195 @@ | ||
<?php | ||
|
||
namespace React\EventLoop; | ||
|
||
use Ev; | ||
use EvLoop; | ||
use React\EventLoop\Tick\FutureTickQueue; | ||
use React\EventLoop\Timer\Timer; | ||
use React\EventLoop\Timer\TimerInterface; | ||
use SplObjectStorage; | ||
|
||
/** | ||
* @see https://bitbucket.org/osmanov/pecl-ev/overview | ||
*/ | ||
class PeclEvLoop implements LoopInterface | ||
{ | ||
private $loop; | ||
private $futureTickQueue; | ||
private $timers; | ||
private $readStreams = []; | ||
private $writeStreams = []; | ||
private $running; | ||
|
||
public function __construct() | ||
{ | ||
$this->loop = new EvLoop(); | ||
$this->futureTickQueue = new FutureTickQueue($this); | ||
$this->timers = new SplObjectStorage(); | ||
} | ||
|
||
public function addReadStream($stream, callable $listener) | ||
{ | ||
$key = (int) $stream; | ||
|
||
if (isset($this->readStreams[$key])) { | ||
return; | ||
} | ||
|
||
$callback = $this->getStreamListenerClosure($stream, $listener); | ||
$event = $this->loop->io($stream, Ev::READ, $callback); | ||
$this->readStreams[$key] = $event; | ||
} | ||
|
||
/** | ||
* @param resource $stream | ||
* @param callable $listener | ||
* | ||
* @return \Closure | ||
*/ | ||
private function getStreamListenerClosure($stream, callable $listener) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor nitpick: Line break before |
||
return function () use ($stream, $listener) { | ||
call_user_func($listener, $stream, $this); | ||
}; | ||
} | ||
|
||
public function addWriteStream($stream, callable $listener) | ||
{ | ||
$key = (int) $stream; | ||
|
||
if (isset($this->writeStreams[$key])) { | ||
return; | ||
} | ||
|
||
$callback = $this->getStreamListenerClosure($stream, $listener); | ||
$event = $this->loop->io($stream, Ev::WRITE, $callback); | ||
$this->writeStreams[$key] = $event; | ||
} | ||
|
||
public function removeReadStream($stream) | ||
{ | ||
$key = (int) $stream; | ||
|
||
if (!isset($this->readStreams[$key])) { | ||
return; | ||
} | ||
|
||
$this->readStreams[$key]->stop(); | ||
unset($this->readStreams[$key]); | ||
} | ||
|
||
public function removeWriteStream($stream) | ||
{ | ||
$key = (int) $stream; | ||
|
||
if (!isset($this->writeStreams[$key])) { | ||
return; | ||
} | ||
|
||
$this->writeStreams[$key]->stop(); | ||
unset($this->writeStreams[$key]); | ||
} | ||
|
||
public function removeStream($stream) | ||
{ | ||
$this->removeReadStream($stream); | ||
$this->removeWriteStream($stream); | ||
} | ||
|
||
public function addTimer($interval, callable $callback) | ||
{ | ||
$timer = new Timer($this, $interval, $callback, false); | ||
|
||
$callback = function () use ($timer) { | ||
call_user_func($timer->getCallback(), $timer); | ||
|
||
if ($this->isTimerActive($timer)) { | ||
$this->cancelTimer($timer); | ||
} | ||
}; | ||
|
||
$event = $this->loop->timer($timer->getInterval(), 0.0, $callback); | ||
$this->timers->attach($timer, $event); | ||
|
||
return $timer; | ||
} | ||
|
||
public function addPeriodicTimer($interval, callable $callback) | ||
{ | ||
$timer = new Timer($this, $interval, $callback, true); | ||
|
||
$callback = function () use ($timer) { | ||
call_user_func($timer->getCallback(), $timer); | ||
}; | ||
|
||
//reschedule callback should be NULL to utilize $offset and $interval params | ||
$event = $this->loop->periodic($interval, $interval, NULL, $callback); | ||
$this->timers->attach($timer, $event); | ||
|
||
return $timer; | ||
} | ||
|
||
public function cancelTimer(TimerInterface $timer) | ||
{ | ||
if (!isset($this->timers[$timer])) { | ||
return; | ||
} | ||
|
||
$event = $this->timers[$timer]; | ||
$event->stop(); | ||
$this->timers->detach($timer); | ||
} | ||
|
||
public function isTimerActive(TimerInterface $timer) | ||
{ | ||
return $this->timers->contains($timer); | ||
} | ||
|
||
public function futureTick(callable $listener) | ||
{ | ||
$this->futureTickQueue->add($listener); | ||
} | ||
|
||
public function run() | ||
{ | ||
$this->running = true; | ||
|
||
while ($this->running) { | ||
$this->futureTickQueue->tick(); | ||
|
||
$hasPendingCallbacks = !$this->futureTickQueue->isEmpty(); | ||
$wasJustStopped = !$this->running; | ||
$nothingLeftToDo = !$this->readStreams && !$this->writeStreams && !$this->timers->count(); | ||
|
||
$flags = Ev::RUN_ONCE; | ||
if ($wasJustStopped || $hasPendingCallbacks) { | ||
$flags |= Ev::RUN_NOWAIT; | ||
} elseif ($nothingLeftToDo) { | ||
break; | ||
} | ||
|
||
$this->loop->run($flags); | ||
} | ||
} | ||
|
||
public function stop() | ||
{ | ||
$this->running = false; | ||
} | ||
|
||
public function __destruct() | ||
{ | ||
/** @var TimerInterface $timer */ | ||
foreach($this->timers as $timer) { | ||
$this->cancelTimer($timer); | ||
} | ||
|
||
foreach($this->readStreams as $key => $stream) { | ||
$this->removeReadStream($key); | ||
} | ||
|
||
foreach($this->writeStreams as $key => $stream) { | ||
$this->removeWriteStream($key); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
namespace React\Tests\EventLoop; | ||
|
||
use React\EventLoop\PeclEvLoop; | ||
|
||
class PeclEvLoopTest extends AbstractLoopTest | ||
{ | ||
public function createLoop() | ||
{ | ||
if (!class_exists('EvLoop')) { | ||
$this->markTestSkipped('pecl-ev tests skipped because ext-ev is not installed.'); | ||
} | ||
|
||
return new PeclEvLoop(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
namespace React\Tests\EventLoop\Timer; | ||
|
||
use React\EventLoop\PeclEvLoop; | ||
|
||
class PeclEvLoopTimerTest extends AbstractTimerTest | ||
{ | ||
public function createLoop() | ||
{ | ||
if (!class_exists('EvLoop')) { | ||
$this->markTestSkipped('pecl-ev tests skipped because ext-ev is not installed.'); | ||
} | ||
|
||
return new PeclEvLoop(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A short description would help?