Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage libevent on PHP 7 #62

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Discourage libevent on PHP 7 #62

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda850f
Discourage libevent on PHP 7
cboden Nov 17, 2016
f1c4746
Remove warning on invalid version mismatch
cboden Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove warning on invalid version mismatch
  • Loading branch information
@cboden @clue
cboden authored and clue committed Oct 13, 2017
commit f1c4746aed686fad34b149eaef37c3ea38eb9df9
4 changes: 0 additions & 4 deletions src/LibEventLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ class LibEventLoop implements LoopInterface

public function __construct()
{
if (version_compare(PHP_VERSION, '7.0.0') >= 0) {
trigger_error('The libevent extension has not yet been updated for PHP 7, it is recommended you use a different loop', E_USER_WARNING);
}

$this->eventBase = event_base_new();
$this->futureTickQueue = new FutureTickQueue();
$this->timerEvents = new SplObjectStorage();
Expand Down