Forward compatibility with PHPUnit 6 and PHPUnit 5#120
Merged
jsor merged 2 commits intoreactphp:masterfrom Nov 15, 2017
carusogabriel:phpunit
Merged
Forward compatibility with PHPUnit 6 and PHPUnit 5#120jsor merged 2 commits intoreactphp:masterfrom carusogabriel:phpunit
jsor merged 2 commits intoreactphp:masterfrom
carusogabriel:phpunit
Conversation
clue
reviewed
Nov 13, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Thank for you digging into this and filing this PR! The changes LGTM, does it make sense to you to add support for PHPUnit 5 and PHPUnit 6 as part of this PR? 
clue
changed the title
clue
approved these changes
Nov 14, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Nice, thank you for the quick update! 👍
Member
|
Awesome! Thanks @Gabriel-Caruso! 🙌 |
cboden
approved these changes
Nov 15, 2017
jsor
approved these changes
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCase. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just need to bump PHPUnit version to
~4.8.35, that support this namespace.