[RFC] Remove removeStream() method, use removeReadStream/removeWriteStream instead #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboden
approved these changes
Nov 10, 2017
|
Seems logical. reactphp/stream and reactphp/zmq will require updating. |
Yep, here's the first PR reactphp/stream#121 |
edusalguero
pushed a commit
to edusalguero/zmq
that referenced
this pull request
Apr 6, 2018
This was referenced Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
removeStream()acts as a shortcut to essentially call bothremoveReadStream()andremoveWriteStream()in one go. It's unclear how much value this method actually provides and it looks like this has attracted some low quality code in the past. As such, I'm filing this PR as an RFC to see if it makes sense to drop this unneeded method.Refs #110