Support resolving from default hosts file #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Aug 16, 2017
kelunik
reviewed
Aug 16, 2017
|
👍 |
WyriHaximus
approved these changes
Aug 18, 2017
jsor
approved these changes
Aug 18, 2017
This was referenced Aug 22, 2017
This was referenced Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Once this is in, you can now create connections to
localhostas expected across all platforms (reactphp/socket#88).This PR adds support for resolving hosts from the system default hosts file. This file is often used for static mappings of certain common hostnames, such as
localhost.The hosts file will be loaded once the
Factorycreates theResolverinstance. The hosts file is loaded on Unix and Windows based systems alike and if this fails, this will simply be ignored and thus preserves the existing behavior. Windows does not store "localhost" in the hosts file by default, but resolves this internally. This PR also adds static mapping for this, so that the DNS resolver now behaves more like the system resolver.The hosts file will be preferred for type
A(IPv4),AAAA(IPv6) andPTR(reverse DNS) requests. For any other type or if no match is found, it will fall back to the default executor so that this does not affect the existing behavior.I know this is a pretty big PR, but I've tried to keep the individual commits so reviewing individual changesets may be easier.
Closes #10
Refs reactphp/socket#88