Closed
Conversation
WyriHaximus
commented
Jul 2, 2017
| $factory = new Factory(); | ||
| $resolver = $factory->create('8.8.8.8', $loop); | ||
|
|
||
| $name = isset($argv[1]) ? $argv[1] : 'blog.wyrihaximus.net'; |
Member
Author
There was a problem hiding this comment.
In case anyone wonders why my own blog, because it is hosted on AWS CloudFront and this always returns more then one IP Address
There was a problem hiding this comment.
Maybe add that as a code comment rather than review comment.
kelunik
reviewed
Jul 2, 2017
| }); | ||
| } | ||
|
|
||
| public function extractAddress(Query $query, Message $response) |
Member
There was a problem hiding this comment.
I agree here, while this method isn't intended to be used from the outside, it's still part of our (current) public API.
clue
reviewed
Jul 2, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Thanks, let's resolve the minor BC break below and let's get this in! 
| }); | ||
| } | ||
|
|
||
| public function extractAddress(Query $query, Message $response) |
Member
There was a problem hiding this comment.
I agree here, while this method isn't intended to be used from the outside, it's still part of our (current) public API.
Member
Author
This was referenced Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status quo with the resolver is that
resolvewill always return oneIPaddress when resolving a hostname, even when the query response yields more. This proposedresolveAllmethod will return all addresses yielded from the query response.