Skip to content

Update travis config to test againt 7.0, 7.1, and nightly #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update travis config to test againt 7.0, 7.1, and nightly #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@ php:
- 5.4
- 5.5
- 5.6
- 7
- 7.0
- 7.1
- nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this library continue to work once a nightly contains breaking changes or PHP 8 or PHP 9 will be released? I'm not sure we can guarantee this, so I would rather remove the "nightly" build here.

Also, I would vote to not merge this yet at least until the issues with PHP 7.1 are resolved 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move nightly to allowed to fail so we know if it works on PHP 8 and PHP 9 before it comes out 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, either that or removing it altogether 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I updated the changes to allow nightly failures. I have not had time to fix the test suite for 7.1 though.

- hhvm

matrix:
allow_failures:
- php: nightly

sudo: false

install:
- composer install --no-interaction

script:
- vendor/bin/phpunit --coverage-text