Target evenement 3.0 a long side 2.0 and 1.0 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change LGTM, but IMO this should target the v1.2.0 release as it is actually a new feature, not a bug fix 👍 For the reference: The failing unit tests are unrelated and being addressed in #17. |
clue
approved these changes
Aug 6, 2017
Don't entirely agree as this doesn't add new features from a users point, it just ensure forward support for a package used in this package. But 🤷♂️ , |
jsor
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Événement
.
3.0is nearly fully backwards compatible with2.0and1.0andreact/datagramis fully compatible with all three so why not support it. It packs some neat performance upgrades without any code changes onreact/datagram's side