Add PHPStan to test environment with max level
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
reviewed
May 23, 2024
| @@ -120,7 +120,7 @@ public function delete(string $key): PromiseInterface; | |||
| * | |||
| * @param string[] $keys A list of keys that can obtained in a single operation. | |||
| * @param mixed $default Default value to return for keys that do not exist. | |||
| * @return PromiseInterface<array> Returns a promise which resolves to an `array` of cached values | |||
| * @return PromiseInterface<array<string,mixed>> Returns a promise which resolves to an `array` of cached values | |||
There was a problem hiding this comment.
Have we considered making the cache typeable? (Out of scope for this PR of course.)
Suggested change
| * @return PromiseInterface<array<string,mixed>> Returns a promise which resolves to an `array` of cached values | |
| * @return PromiseInterface<array<string,T>> Returns a promise which resolves to an `array` of cached values |
There was a problem hiding this comment.
Not sure how useful this is, but happy to discuss in a separate PR if this is something you want to look into 👍
There was a problem hiding this comment.
I will do a PR once this is in together with one for DNS to show that off after doing some more research 👍 .
WyriHaximus
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds PHPStan on
maxlevel to the test environment for all supported PHP versions as discussed in #56. It runs the maximum level supported with all errors addressed without having to resort to a baseline. The changeset size seems reasonable and this does not other affect our public API, so this should be safe to apply.Builds on top of #60, #59, #58, #44 and reactphp/async#76