Skip to content

[WIP] Add test case for SSL connections #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[WIP] Add test case for SSL connections #16

wants to merge 4 commits into from

Conversation

clue
Copy link
Contributor

@clue clue commented Sep 7, 2014

Refs #13 and #14

@clue clue force-pushed the test branch 2 times, most recently from ebbc08a to 24c7fbe Compare September 7, 2014 10:38
@cboden
Copy link
Contributor

cboden commented Sep 7, 2014

Shouldn't the tests be failing on 5.4 and 5.5 as well?

@clue
Disable peer verification
a39eea7 
This allows us to test our self-signed certificate
@cboden cboden mentioned this pull request Sep 10, 2014
Closed
@clue clue mentioned this pull request Feb 5, 2015
Merged
@clue
Copy link
Contributor Author

clue commented Feb 23, 2015

Depends on #4 to disable peer verification to support self-signed certificates.

See also #18 as an alternative to this PR that uses trusted/public certificates.

@clue clue mentioned this pull request Mar 11, 2015
Merged
@clue
Copy link
Contributor Author

clue commented Sep 7, 2015

There's no immediate use for this now that #18 has been merged a while ago.

I'll look into reopening a new PR once #4 has been resolved.

@clue clue closed this Sep 7, 2015
@clue clue mentioned this pull request Mar 8, 2016
Closed
@clue clue deleted the test branch March 9, 2016 21:21
@clue clue mentioned this pull request Mar 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @cboden