[ADVAPI32] Fix undue debug print in nominal case #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarymaster
approved these changes
May 4, 2020
binarymaster
changed the title
|
Thanks |
ghost
deleted the
vgalnt
pushed a commit
to vgalnt/reactos
that referenced
this pull request
Feb 4, 2025
In current implementation, when regedit opens HKCR root key, an error is logged err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259. This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259.
This is not correct as code 259 is for ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
Proposed changes
Err is not displayed when ERROR_NO_MORE_ITEMS is returned.