[SYSDM][DESK] Fix GetDC/ReleaseDC error management #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katahiromz
reviewed
May 1, 2020
|
Thanks @katahiromz for your comments. I've also pushed some refactoring to further improve error management. |
ghost
changed the title
katahiromz
reviewed
May 1, 2020
katahiromz
approved these changes
May 1, 2020
|
I've added LiveCD Userinit, which is based on SYSDM. Ready for review. |
ghost
mentioned this pull request
katahiromz
pushed a commit
that referenced
this pull request
May 2, 2020
GetDC() is called without properly calling ReleaseDC() as required in order to releases a device context. Similar to #2707
katahiromz
reviewed
May 2, 2020
katahiromz
reviewed
May 2, 2020
HBelusca
reviewed
May 2, 2020
|
All comments taken into account. |
katahiromz
approved these changes
May 2, 2020
|
Thank you @SergeGautherie for your review. Unless I did something wrong all your comments should be included in last commit. |
|
@SergeGautherie : Comments included and justification of design proposed. Regarding hSpectrum, Git did not proposed that I could reply but if GetDC fails to provide hSpectrumDC it's better to exit the OnBPPChanged without further effect, in order to be a consistent mode (prior to change) rather than half way the code processing, with execution of other instructions over a NULL context. |
ghost
requested a review
from
HBelusca
reviewed
May 3, 2020
|
@HBelusca : Do you still have comments based on the last changes i've made ? Or are you OK to approve ? |
|
@binarymaster : Please set the "bug fix" label too for the ReleaseDC part. |
HBelusca
approved these changes
May 7, 2020
|
Thanks ! |
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
JoachimHenze
added a commit
that referenced
this pull request
Jul 5, 2021
Fix missing ReleaseDC related to the spectrum (color depth) We leaked one device context for each bpp change within the desk.cpl-session, which gave the following logging when closing desk.cpl: (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! 1 time for each leak. Partial backport of (#2707) Fix picked from 0.4.15-dev-2867-g d635ce0
vgalnt
pushed a commit
to vgalnt/reactos
that referenced
this pull request
Feb 4, 2025
GetDC() is called without properly calling ReleaseDC() as required in order to releases a device context. Similar to reactos#2707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[SYSDM]
(win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()!
because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to releases a device context.
[DESK]
Proposed changes