Skip to content

Conversation

@o-
Copy link
Contributor

@o- o- commented Jun 23, 2021

if we move an environment over a PushContext we need to update its
context offset field, or it will register itself to the wrong context.
E.g.

e1 = mkenv context 1
     PushContext ... e2
     Checkpoint ....

if we move e1 into the checkpoint, then the context must be increased
to 2, otherwise it will override the environment e2 in the inlined
context.

if we move an environment over a PushContext we need to update its
context offset field, or it will register itself to the wrong context.
E.g.

    e1 = mkenv context 1
         PushContext ... e2
         Checkpoint ....

if we move `e1` into the checkpoint, then the context must be increased
to 2, otherwise it will override the environment `e2` in the inlined
context.
@o-
Copy link
Contributor Author

o- commented Jun 23, 2021

Here are some stats for your PR:

  • WARNING: the longest CI job test_release_2 took 2.0h
  • are-we-fast-r suite regressed by 0.88
  • Mandelbrot regressed by 0.69
  • Bounce_nonames_simple regressed by 0.88
  • Bounce_nonames regressed by 0.92
  • fannkuchredux regressed by 0.84
  • reversecomplement_naive regressed by 0.92
  • matrixFor regressed by 0.95
  • Overall benchmarks regressed by 0.99

Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=1371658575&job_ids[]=1370735306&selection=all

@o-
Copy link
Contributor Author

o- commented Jun 23, 2021

Here are some stats for your PR:

  • WARNING: the longest CI job test_release_1 took 2.17h
  • are-we-fast-r suite regressed by 0.95
  • Mandelbrot regressed by 0.88
  • Bounce_nonames regressed by 0.92
  • Bounce_nonames_simple regressed by 0.94
  • emptyFor regressed by 0.95
  • Overall benchmarks regressed by 1.0

Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=1372008748&job_ids[]=1370735306&selection=all

@o- o- force-pushed the fixScopeResolutionEnv branch from 445f470 to e3b9053 Compare June 24, 2021 06:45
@o-
Copy link
Contributor Author

o- commented Jun 24, 2021

Here are some stats for your PR:

  • WARNING: the longest CI job test_big_inline took 2.36h
  • Overall benchmarks improved by 1.0

Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=1372987311&job_ids[]=1371671945&selection=all

@o- o- merged commit 863fa3c into master Jun 24, 2021
@o- o- deleted the fixScopeResolutionEnv branch June 24, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants