Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability to log response headers in access logs #1505

Closed
nikban95 opened this issue Feb 10, 2021 · 0 comments · Fixed by #1506
Closed

Capability to log response headers in access logs #1505

nikban95 opened this issue Feb 10, 2021 · 0 comments · Fixed by #1506
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Milestone
1.0.4

Comments

@nikban95
Copy link

Capability to log response headers in access logs

Motivation

Currently below fields can be logged in access logs:
zonedDateTime, remoteAddress, method, uri, protocol, user, status, contentLength, duration, requestHeader
As responseHeader is also an important usecase to log.

This jira is to add the capability to log responseHeader
@nikban95 nikban95 added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Feb 10, 2021
@nikban95 nikban95 mentioned this issue Feb 10, 2021
Closed
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Feb 10, 2021
@violetagg violetagg added this to the 1.0.x Backlog milestone Feb 10, 2021
@violetagg violetagg added the good first issue Ideal for a new contributor, we'll help label Feb 10, 2021
@immuthex immuthex mentioned this issue Feb 10, 2021
Merged
@violetagg violetagg linked a pull request Feb 10, 2021 that will close this issue
fix #1505 Expose the response headers via AccessLogArgProvider #1506
Merged
@violetagg violetagg modified the milestones: 1.0.x Backlog, 1.0.4 Feb 10, 2021
violetagg pushed a commit that referenced this issue Feb 10, 2021
fix #1505 Expose the response headers via AccessLogArgProvider (#1506)
b26b42c
@violetagg violetagg mentioned this issue Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

fix #1505 Expose the response headers via AccessLogArgProvider immuthex/reactor-netty
2 participants
@violetagg @nikban95