Skip to content

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Sep 17, 2025

Upon community request, this PR upgrades the kafka-clients dependency to 3.9.1.

Resolves #409

Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
@chemicL chemicL added this to the 1.3.24 milestone Sep 17, 2025
@chemicL chemicL added the type/enhancement A general enhancement label Sep 17, 2025
@chemicL
Copy link
Member Author

chemicL commented Sep 17, 2025

@mxcross, @maksimlikharevau, would you be so kind to validate if this upgrade works fine in your setup? If that's the case, I'd be happy to merge and release this.

@maksimlikharevau
Copy link

the only question would be,

public Uuid clientInstanceId(Duration timeout) {
        throw new UnsupportedOperationException("clientInstanceId not supported");
    }

maybe throw IllegalStateException, to be in line with API contract, other than that it looks good.

@chemicL
Copy link
Member Author

chemicL commented Sep 18, 2025

public Uuid clientInstanceId(Duration timeout) {
        throw new UnsupportedOperationException("clientInstanceId not supported");
    }

maybe throw IllegalStateException, to be in line with API contract, other than that it looks good.

Actually, this code is in a supporting test class (reactor.kafka.mock.MockProducer) and the UnsupportedOperationException was inspired by the code in kafka-clients library itself in org.apache.kafka.clients.producer.MockProducer#clientInstanceId:

        if (telemetryDisabled) {
            throw new IllegalStateException();
        }
        if (clientInstanceId == null) {
            throw new UnsupportedOperationException("clientInstanceId not set");
        }
        // ...

@chemicL
Copy link
Member Author

chemicL commented Sep 18, 2025

Let's gather some community feedback if this is actually desired. The simple solution is to simply specify the kafka-clients dependency explicitly using your build tool.

@maksimlikharevau
Copy link

I honestly have no strong opinion, my comment was simply due to the list of exceptions thrown from the method in the API doc, UnsupportedOperationException would work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the kafka-clients library to 3.9.0
2 participants