GH-421: Fix behavior of undoCommitAhead #422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During graceful shutdown at-most-once Kafka consumer with atmostOnceCommitAheadSize option configured reverts offsets committed ahead and commits offsets of the latest records dispatched down the stream. The offsets were off by one and after undoCommitAhead consumer group was left with consumer lag of -1. Signed-off-by: Mikołaj Bul <mikolajbul@gmail.com>
…head During graceful shutdown at-most-once Kafka consumer with atmostOnceCommitAheadSize option configured can commit offsets on partitions that have been revoked from it. This might break processing guarantees for other consumers by making them process records multiple times. To address this issue another action was added to onPartitionsRevoked hook - offsets of revoked partitions are cleared from AtmostOnceOffsets class. Signed-off-by: Mikołaj Bul <mikolajbul@gmail.com>
…tions Closing the consumer happens after performing undoCommitAhead. Ensure no race conditions are present in undoCommitAhead assertions by waiting for the consumer to close. Signed-off-by: Mikołaj Bul <mikolajbul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #421.
Proposed changeset:
AtmostOnceOffsetsundoCommitAhead