Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see #887 Workaround the source jar java file duplication issue #888

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

simonbasle
Copy link
Member

See https://youtrack.jetbrains.com/issue/KT-17564
Will be fixed in kotlin-gradle-plugin 1.1.60

@simonbasle simonbasle requested a review from sdeleuze October 2, 2017 09:51
@codecov-io
Copy link

Codecov Report

Merging #888 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #888      +/-   ##
============================================
- Coverage     83.67%   83.65%   -0.02%     
- Complexity     3280     3283       +3     
============================================
  Files           319      319              
  Lines         25985    25985              
  Branches       4813     4813              
============================================
- Hits          21742    21738       -4     
- Misses         2796     2799       +3     
- Partials       1447     1448       +1
Impacted Files Coverage Δ Complexity Δ
...ava/reactor/core/publisher/WorkQueueProcessor.java 69.06% <0%> (-1.28%) 19% <0%> (ø)
...ain/java/reactor/core/publisher/FluxPublishOn.java 87.6% <0%> (-0.64%) 5% <0%> (ø)
.../main/java/reactor/core/publisher/FluxFlatMap.java 94.37% <0%> (-0.41%) 13% <0%> (ø)
...rc/main/java/reactor/core/publisher/Operators.java 72% <0%> (+0.18%) 81% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxExpand.java 94.22% <0%> (+0.44%) 3% <0%> (ø) ⬇️
...n/java/reactor/core/publisher/DirectProcessor.java 86.66% <0%> (+0.83%) 30% <0%> (+1%) ⬆️
...main/java/reactor/core/publisher/SignalLogger.java 59.82% <0%> (+0.85%) 44% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be3b2e...65d8a33. Read the comment docs.

Copy link
Contributor

@sdeleuze sdeleuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that the source JAR does not contain duplicated entries anymore.

@simonbasle simonbasle merged commit a0a913a into master Oct 2, 2017
@simonbasle simonbasle deleted the 887-avoidDuplicateSourceFiles branch October 2, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants