Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MonoPublishOnTest flakiness #3898

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix MonoPublishOnTest flakiness #3898

merged 2 commits into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. Fix MonoPublishOnTest flakiness 

    The implementation relied on a specific sequencing of events, which in
case of slower hardware or random events would occasionally fail the
assertions. This change introduces firm ordering and fixes an incorrect
assertion, which assumed the `Mono` terminates without error, while in
fact the `RejectedExecutionException` is propagated to the
`AssertSubscriber`. In effect, the tests are no longer flaky.
    @chemicL
    chemicL committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    12861e0 View commit details
    Browse the repository at this point in the history

  2. formatting

    @chemicL
    chemicL committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    86ca636 View commit details
    Browse the repository at this point in the history