ensures that proper index is used during onNext check #3614

OlegDokuka · 2023-10-06T10:45:22Z

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>

chemicL · 2023-10-09T06:54:12Z

reactor-core/src/test/java/reactor/core/publisher/FluxBufferTimeoutTest.java

-			for (Integer i : integers) {
-				if (!seen.add(i)) {
-					throw new IllegalStateException("Duplicate! " + i);
+		for (int i = 0; i < 100; i++) {


The changes in the test look like were introduced because the race testing utils are not trusted. At the same time, changing a test at the same time while introducing a change to the production code is suspicious - are these the final changes? Do we want to repeat the test 100 times?

First of all the this race test check was written incorrectly and did not verify the original intent (e.g. to check no racy calls on downstream Subscriber#onNext)

Secondly, the method being tested is probability related thing. Just running race test once gives no guarantee of event to occur. JCStress are doing the same underneath (looping many times until a possible event is being triggered). Here, we do that manually.

Ideally that should be moved to JCStress suit which does that in more sophisticated way (e.g. adds different VM configurations in addition which may create higher probability to a specific event occurrence).

There should be a separate effort moving all such tests to JCStress. For now just wanna eliminate the bug

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>

Signed-off-by: OlegDokuka <odokuka@vmware.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | openjdk | final | patch | `17` -> `17.0.2` | [![age](https://developer.mend.io/api/mc/badges/age/docker/openjdk/17.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/openjdk/17.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/openjdk/17/17.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/openjdk/17/17.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [secops](https://circleci.com/developer/orbs/orb/apollo/circleci-secops-orb) | orb | patch | `2.0.6` -> `2.0.7` | [![age](https://developer.mend.io/api/mc/badges/age/orb/secops/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/orb/secops/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/orb/secops/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/orb/secops/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [com.diffplug.spotless:spotless-plugin-gradle](https://togithub.com/diffplug/spotless) | devDependencies | minor | `6.21.0` -> `6.24.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.diffplug.spotless:spotless-plugin-gradle/6.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.diffplug.spotless:spotless-plugin-gradle/6.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.diffplug.spotless:spotless-plugin-gradle/6.21.0/6.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.diffplug.spotless:spotless-plugin-gradle/6.21.0/6.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.junit.jupiter:junit-jupiter](https://junit.org/junit5/) ([source](https://togithub.com/junit-team/junit5)) | dependencies | patch | `5.10.0` -> `5.10.1` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.junit.jupiter:junit-jupiter/5.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.junit.jupiter:junit-jupiter/5.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.junit.jupiter:junit-jupiter/5.10.0/5.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.junit.jupiter:junit-jupiter/5.10.0/5.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.projectreactor:reactor-test](https://togithub.com/reactor/reactor-core) | dependencies | minor | `3.5.9` -> `3.6.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.projectreactor:reactor-test/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.projectreactor:reactor-test/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.projectreactor:reactor-test/3.5.9/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.projectreactor:reactor-test/3.5.9/3.6.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.graphql:spring-graphql-test](https://togithub.com/spring-projects/spring-graphql) | dependencies | patch | `1.2.3` -> `1.2.4` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.graphql:spring-graphql-test/1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.graphql:spring-graphql-test/1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.graphql:spring-graphql-test/1.2.3/1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.graphql:spring-graphql-test/1.2.3/1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-websocket](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | dependencies | minor | `3.1.4` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-websocket/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-websocket/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-websocket/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-websocket/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-test](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | dependencies | minor | `3.1.4` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-test/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-test/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-test/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-test/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-webflux](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | dependencies | minor | `3.1.4` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-webflux/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-webflux/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-webflux/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-webflux/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-web](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | dependencies | minor | `3.1.4` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-web/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-web/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-web/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-web/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-graphql](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | dependencies | minor | `3.1.4` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-graphql/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-graphql/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-graphql/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-graphql/3.1.4/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.slf4j:slf4j-api](http://www.slf4j.org) ([source](https://togithub.com/qos-ch/slf4j)) | dependencies | patch | `2.0.9` -> `2.0.11` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.slf4j:slf4j-api/2.0.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.slf4j:slf4j-api/2.0.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.slf4j:slf4j-api/2.0.9/2.0.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.slf4j:slf4j-api/2.0.9/2.0.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [com.squareup.okhttp3:mockwebserver](https://square.github.io/okhttp/) ([source](https://togithub.com/square/okhttp)) | dependencies | minor | `4.11.0` -> `4.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.squareup.okhttp3:mockwebserver/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.squareup.okhttp3:mockwebserver/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.squareup.okhttp3:mockwebserver/4.11.0/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.squareup.okhttp3:mockwebserver/4.11.0/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | io.spring.dependency-management | plugin | patch | `1.1.3` -> `1.1.4` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.spring.dependency-management/1.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.spring.dependency-management/1.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.spring.dependency-management/1.1.3/1.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.spring.dependency-management/1.1.3/1.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.jetbrains:annotations](https://togithub.com/JetBrains/java-annotations) | dependencies | minor | `24.0.1` -> `24.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.jetbrains:annotations/24.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.jetbrains:annotations/24.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.jetbrains:annotations/24.0.1/24.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.jetbrains:annotations/24.0.1/24.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | org.springframework.boot | plugin | minor | `3.1.3` -> `3.2.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot/3.1.3/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot/3.1.3/3.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reactor/reactor-core (io.projectreactor:reactor-test)</summary> ### [`v3.6.2`](https://togithub.com/reactor/reactor-core/releases/tag/v3.6.2) [Compare Source](https://togithub.com/reactor/reactor-core/compare/v3.6.1...v3.6.2)  #### What's Changed ##### :warning: Update considerations and deprecations - Restore where onLastOperatorHook is applied by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3673](https://togithub.com/reactor/reactor-core/pull/3673) ##### :lady_beetle: Bug fixes - ensure error is not propagated on cancellation and onNext race by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3665](https://togithub.com/reactor/reactor-core/pull/3665) - Fix pendingTask count not tracking task rejection by [@Nicolas125841](https://togithub.com/Nicolas125841) in [https://github.com/reactor/reactor-core/pull/3660](https://togithub.com/reactor/reactor-core/pull/3660) ##### :book: Documentation, Tests and Build - Fix sample code typos in Mono javadocs by [@valery1707](https://togithub.com/valery1707) in [https://github.com/reactor/reactor-core/pull/3657](https://togithub.com/reactor/reactor-core/pull/3657) - Remove unused com.gradle.enterprise plugin by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3668](https://togithub.com/reactor/reactor-core/pull/3668) - Fix flaky test for pending tasks count validation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3669](https://togithub.com/reactor/reactor-core/pull/3669) - Fix flaky test for BoundedElasticThreadPerTaskScheduler by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3679](https://togithub.com/reactor/reactor-core/pull/3679) - Improve RaceTestUtils to yield when CPUs don't suffice by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3678](https://togithub.com/reactor/reactor-core/pull/3678) - Remove overridden methods from GenericBoundedElasticThreadPerTask… by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3685](https://togithub.com/reactor/reactor-core/pull/3685) - Exclude loom boundedElastic from restart validation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3686](https://togithub.com/reactor/reactor-core/pull/3686) ##### :up: Dependency Upgrades - Bump byteBuddyVersion from 1.14.9 to 1.14.10 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3659](https://togithub.com/reactor/reactor-core/pull/3659) - Bump org.junit:junit-bom from 5.10.0 to 5.10.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3680](https://togithub.com/reactor/reactor-core/pull/3680) - Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3681](https://togithub.com/reactor/reactor-core/pull/3681) - Bump ch.qos.logback:logback-classic from 1.2.12 to 1.2.13 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3684](https://togithub.com/reactor/reactor-core/pull/3684) - Bump byteBuddyVersion from 1.14.10 to 1.14.11 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3683](https://togithub.com/reactor/reactor-core/pull/3683) #### New Contributors - [@Nicolas125841](https://togithub.com/Nicolas125841) made their first contribution in [https://github.com/reactor/reactor-core/pull/3660](https://togithub.com/reactor/reactor-core/pull/3660) - [@valery1707](https://togithub.com/valery1707) made their first contribution in [https://github.com/reactor/reactor-core/pull/3657](https://togithub.com/reactor/reactor-core/pull/3657) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.6.1...v3.6.2 ### [`v3.6.1`](https://togithub.com/reactor/reactor-core/releases/tag/v3.6.1)  `Reactor Core` `3.6.1` is part of **`2023.0.1` Release Train**. #### What's Changed ##### :lady_beetle: Bug fixes - `SinkManyUnicast` discard support during subscription cancel by [@chemicL](https://togithub.com/chemicL) in [#3641](https://togithub.com/reactor/reactor-core/issues/3641), [`1bee07c`](https://togithub.com/reactor/reactor-core/commit/1bee07c56b955e2102a884fb2d3b82f2deee64e1) - Ensure scheduler is initialised by [@OlegDokuka](https://togithub.com/OlegDokuka) in [`06bf103`](https://togithub.com/reactor/reactor-core/commit/06bf103de8db24d3e3f118f3cdfb257e8304b8a0) ##### :book: Documentation, Tests and Build - `MemoryUtils.Tracked` used in tests releases collections by [@chemicL](https://togithub.com/chemicL) in [#3328](https://togithub.com/reactor/reactor-core/issues/3328) - Final method declaration in final class by [@subbarao](https://togithub.com/subbarao) in [#3461](https://togithub.com/reactor/reactor-core/issues/3461) - Update `reactiveProgramming.adoc` by [@Navaneethsen](https://togithub.com/Navaneethsen) in [#3592](https://togithub.com/reactor/reactor-core/issues/3592) - Add `@Override` annotations in sample java code by [@ByoungJoonIm](https://togithub.com/ByoungJoonIm) in [#3605](https://togithub.com/reactor/reactor-core/issues/3605) - Improve documentation for `VirtualThread`s `boundedElastic` behaviour by [@OlegDokuka](https://togithub.com/OlegDokuka) in [#3635](https://togithub.com/reactor/reactor-core/issues/3635) - `StressSubscriber` `discardedValues` should not have downstream type by [@chemicL](https://togithub.com/chemicL) in [#3643](https://togithub.com/reactor/reactor-core/issues/3643) - Add `Pull Request` template by [@chemicL](https://togithub.com/chemicL) in [#3650](https://togithub.com/reactor/reactor-core/issues/3650) ##### :up: Dependency Upgrades - Bump `byteBuddyVersion` from `1.14.8` to `1.14.9` by [@dependabot](https://togithub.com/dependabot) in [#3619](https://togithub.com/reactor/reactor-core/issues/3619) - Bump `Micrometer` libs versions by [@OlegDokuka](https://togithub.com/OlegDokuka) in [#3662](https://togithub.com/reactor/reactor-core/issues/3662) #### New Contributors - [@Navaneethsen](https://togithub.com/Navaneethsen) made their first contribution in [#3592](https://togithub.com/reactor/reactor-core/issues/3592) - [@ByoungJoonIm](https://togithub.com/ByoungJoonIm) made their first contribution in [#3605](https://togithub.com/reactor/reactor-core/issues/3605) - [@subbarao](https://togithub.com/subbarao) made their first contribution in [#3461](https://togithub.com/reactor/reactor-core/issues/3461) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.6.0...v3.6.1 ### [`v3.6.0`](https://togithub.com/reactor/reactor-core/releases/tag/v3.6.0)  Reactor-Core 3.6.0 is part of 2023.0.0 Release Train. This is the first GA release of 2023.0.0 🎉 This note focuses on 3.6.0 proper, curating changes from across all milestones and also includes changes already released as part of 3.4.x line up to 3.4.34 as well as 3.5.x line up to 3.5.12. While there are plenty of improvements and bug fixes, it's worth to highlight the bigger themes first: - The `Schedulers.boundedElastic()` may return a specific implementation tailored for [Project Loom](https://openjdk.org/projects/loom/) and running on virtual threads if application runs in Java 21+ runtime and have set the `reactor.schedulers.defaultBoundedElasticOnVirtualThreads` system property to `true`. Please consult the [javadocs](https://projectreactor.io/docs/core/snapshot/api/reactor/core/scheduler/Schedulers.html#boundedElastic--) and [the reference documentation](https://projectreactor.io/docs/core/snapshot/reference/#schedulers) for more information. - Support for [Multi-Release Jar](https://openjdk.org/jeps/238). Since this release project has java version specific sources that are enabled if runs in specific Java runtime. This allows to avoid unnecessary reflection checks as well as embrace some new neat java features without changing the baseline for the whole code base. - Hardening of the context-propagation. This release introduces better support for external `Publisher`s detection with their corresponding decoration if detected. This enables more stable context-propagation when it comes to external libraries integration. See dedicated pre-release [blogpost](https://spring.io/blog/2023/10/31/what-new-is-coming-in-reactor-core-3-6-0#virtual-threads-support) for more information. #### What's Changed ##### :warning: Update considerations and deprecations - ensures `addCap` always returns value with flag by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3610](https://togithub.com/reactor/reactor-core/pull/3610) - makes `throwable` assignment happens-before `done` assignment in `onError` for FluxPublish by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3638](https://togithub.com/reactor/reactor-core/pull/3638) ##### :sparkles: New features and improvements - Hardening automatic context propagation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3549](https://togithub.com/reactor/reactor-core/pull/3549) - InternalOperator automatic context propagation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3625](https://togithub.com/reactor/reactor-core/pull/3625) - adds support for gradle 8.1.1 by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3521](https://togithub.com/reactor/reactor-core/pull/3521) - adds support for multi-release-jar | rework `Traces` by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3523](https://togithub.com/reactor/reactor-core/pull/3523) - introduces automatic loom support by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3524](https://togithub.com/reactor/reactor-core/pull/3524) - provides minimal troubleshooting for mrj by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3532](https://togithub.com/reactor/reactor-core/pull/3532) - fix [#3539](https://togithub.com/reactor/reactor-core/issues/3539) takeUntil Predicate test before emit by [@AramMessdaghi9001](https://togithub.com/AramMessdaghi9001) in [https://github.com/reactor/reactor-core/pull/3544](https://togithub.com/reactor/reactor-core/pull/3544) - Reworks FluxPublish internals to relay on predictable state machine by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3538](https://togithub.com/reactor/reactor-core/pull/3538) - dedicated loom oriented boundeElasticScheduler implementation by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3566](https://togithub.com/reactor/reactor-core/pull/3566) - Handling 1.0.0 of context-propagation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3609](https://togithub.com/reactor/reactor-core/pull/3609) - provides extra check for contextualName presence by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3611](https://togithub.com/reactor/reactor-core/pull/3611) - JCStress: Await Scheduler dispose and increase timeouts by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3630](https://togithub.com/reactor/reactor-core/pull/3630) ##### :lady_beetle: Bug fixes - fixes `MonoDelayElement` to properly handle race between delay `run` and `onNext` signal by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3546](https://togithub.com/reactor/reactor-core/pull/3546) - ensures `GroupedFlux` delivers subscription for the second subscriber by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3555](https://togithub.com/reactor/reactor-core/pull/3555) - ensures late `onRequest` consumer observes demand by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3557](https://togithub.com/reactor/reactor-core/pull/3557) - ensures that proper index is used during onNext check by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3614](https://togithub.com/reactor/reactor-core/pull/3614) - ensures SchedulerTask uses isShutdown instead of isDisposed by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3623](https://togithub.com/reactor/reactor-core/pull/3623) ##### :book: Documentation, Tests and Build - Fix return type for Mono.tap in javadoc by [@ajax-surovskyi-y](https://togithub.com/ajax-surovskyi-y) in [https://github.com/reactor/reactor-core/pull/3564](https://togithub.com/reactor/reactor-core/pull/3564) - fixes CI.yml by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3575](https://togithub.com/reactor/reactor-core/pull/3575) - adds CI nightly builds by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3581](https://togithub.com/reactor/reactor-core/pull/3581) - disables temporarily java 21 tests by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3590](https://togithub.com/reactor/reactor-core/pull/3590) - Bump actions/setup-java from 3.12.0 to 3.13.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3585](https://togithub.com/reactor/reactor-core/pull/3585) - Bump actions/checkout from 3.1.0 to 4.1.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3586](https://togithub.com/reactor/reactor-core/pull/3586) - Bump gradle/gradle-build-action from 2.7.0 to 2.9.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3594](https://togithub.com/reactor/reactor-core/pull/3594) - improves build speed by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3597](https://togithub.com/reactor/reactor-core/pull/3597) - Revised documentation about context propagation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3617](https://togithub.com/reactor/reactor-core/pull/3617) - updates to java 21 GA temurin by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3631](https://togithub.com/reactor/reactor-core/pull/3631) - Gradle 8.4 upgrade by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3632](https://togithub.com/reactor/reactor-core/pull/3632) ##### :up: Dependency Upgrades - Bump gradle/wrapper-validation-action from 1.0.5 to 1.1.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3542](https://togithub.com/reactor/reactor-core/pull/3542) - Bump com.gradle.enterprise from 3.12.4 to 3.14.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3548](https://togithub.com/reactor/reactor-core/pull/3548) - Bump actions/setup-java from 3.6.0 to 3.12.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3550](https://togithub.com/reactor/reactor-core/pull/3550) - Bump gradle/gradle-build-action from 2.3.3 to 2.7.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3551](https://togithub.com/reactor/reactor-core/pull/3551) - Update `Micrometer` version to `1.10.10` by [@violetagg](https://togithub.com/violetagg) in [https://github.com/reactor/reactor-core/pull/3560](https://togithub.com/reactor/reactor-core/pull/3560) - upgrades to latest micrometer versions by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3561](https://togithub.com/reactor/reactor-core/pull/3561) - Bump io.spring.nohttp from 0.0.10 to 0.0.11 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3497](https://togithub.com/reactor/reactor-core/pull/3497) - Bump org.junit:junit-bom from 5.9.2 to 5.10.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3556](https://togithub.com/reactor/reactor-core/pull/3556) - Bump me.champeau.gradle.japicmp from 0.4.1 to 0.4.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3595](https://togithub.com/reactor/reactor-core/pull/3595) - Bump jmhVersion from 1.36 to 1.37 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3596](https://togithub.com/reactor/reactor-core/pull/3596) - Bump byteBuddyVersion from 1.14.5 to 1.14.8 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3601](https://togithub.com/reactor/reactor-core/pull/3601) - Bump com.gradle.enterprise from 3.14.1 to 3.15 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3602](https://togithub.com/reactor/reactor-core/pull/3602) - Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.12 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3476](https://togithub.com/reactor/reactor-core/pull/3476) - Bump de.undercouch.download from 5.4.0 to 5.5.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3608](https://togithub.com/reactor/reactor-core/pull/3608) - Bump com.gradle.enterprise from 3.15 to 3.15.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3613](https://togithub.com/reactor/reactor-core/pull/3613) - Update micrometer and micrometerTracing by [@pderop](https://togithub.com/pderop) in [https://github.com/reactor/reactor-core/pull/3636](https://togithub.com/reactor/reactor-core/pull/3636) - Update micrometer, micrometerTracing, contextPropagation by [@pderop](https://togithub.com/pderop) in [https://github.com/reactor/reactor-core/pull/3637](https://togithub.com/reactor/reactor-core/pull/3637) #### New Contributors - [@AramMessdaghi9001](https://togithub.com/AramMessdaghi9001) made their first contribution in [https://github.com/reactor/reactor-core/pull/3544](https://togithub.com/reactor/reactor-core/pull/3544) - [@ajax-surovskyi-y](https://togithub.com/ajax-surovskyi-y) made their first contribution in [https://github.com/reactor/reactor-core/pull/3564](https://togithub.com/reactor/reactor-core/pull/3564) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.5.8...v3.6.0 ### [`v3.5.14`](https://togithub.com/reactor/reactor-core/compare/v3.5.13...v3.5.14) ### [`v3.5.13`](https://togithub.com/reactor/reactor-core/releases/tag/v3.5.13)  `Reactor Core` `3.5.13` is part of **`2022.0.14` Release Train**. #### What's Changed ##### :lady_beetle: Bug fixes - `SinkManyUnicast` discard support during subscription cancel by [@chemicL](https://togithub.com/chemicL) in [#3641](https://togithub.com/reactor/reactor-core/issues/3641) ##### :book: Documentation, Tests and Build - `MemoryUtils.Tracked` used in tests releases collections by [@chemicL](https://togithub.com/chemicL) in [#3328](https://togithub.com/reactor/reactor-core/issues/3328) - `StressSubscriber` `discardedValues` should not have downstream type by [@chemicL](https://togithub.com/chemicL) in [#3643](https://togithub.com/reactor/reactor-core/issues/3643) ##### :up: Dependency Upgrades - Bump `byteBuddyVersion` from `1.14.8` to `1.14.9` by [@dependabot](https://togithub.com/dependabot) in [#3619](https://togithub.com/reactor/reactor-core/issues/3619) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.5.12...v3.5.13 ### [`v3.5.12`](https://togithub.com/reactor/reactor-core/releases/tag/v3.5.12)  `Reactor Core` `3.5.12` is part of **`2022.0.13` Release Train**. #### What's Changed ##### :warning: Update considerations and deprecations - Make `throwable` assignment happens-before `done` assignment in `onError` for `FluxPublish` by [@OlegDokuka](https://togithub.com/OlegDokuka) in [#3638](https://togithub.com/reactor/reactor-core/issues/3638) ##### :sparkles: New features and improvements - `JCStress`: Await `Scheduler` dispose and increase timeouts by [@chemicL](https://togithub.com/chemicL) in [#3630](https://togithub.com/reactor/reactor-core/issues/3630) ##### :up: Dependency Upgrades - Update `Micrometer` and `Micrometer Tracing` by [@pderop](https://togithub.com/pderop) in [#3636](https://togithub.com/reactor/reactor-core/issues/3636) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.5.11...v3.5.12 ### [`v3.5.11`](https://togithub.com/reactor/reactor-core/releases/tag/v3.5.11) [Compare Source](https://togithub.com/reactor/reactor-core/compare/v3.5.10...v3.5.11)  #### What's Changed ##### :warning: Update considerations and deprecations - ensures `addCap` always returns value with flag by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3610](https://togithub.com/reactor/reactor-core/pull/3610) ##### :sparkles: New features and improvements - provides extra check for `contextualName` presence by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3611](https://togithub.com/reactor/reactor-core/pull/3611) - Handling 1.0.0 of context-propagation by [@chemicL](https://togithub.com/chemicL) in [https://github.com/reactor/reactor-core/pull/3609](https://togithub.com/reactor/reactor-core/pull/3609) ##### :lady_beetle: Bug fixes - ensures that `FluxBufferTime` uses proper `index` value during `onNext` check by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3614](https://togithub.com/reactor/reactor-core/pull/3614) ##### :book: Documentation, Tests and Build - adds CI nightly builds by [@OlegDokuka](https://togithub.com/OlegDokuka) in [https://github.com/reactor/reactor-core/pull/3581](https://togithub.com/reactor/reactor-core/pull/3581) - Bump actions/setup-java from 3.12.0 to 3.13.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3585](https://togithub.com/reactor/reactor-core/pull/3585) - Bump actions/checkout from 3.1.0 to 4.1.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3586](https://togithub.com/reactor/reactor-core/pull/3586) - Bump gradle/gradle-build-action from 2.7.0 to 2.9.0 in /.github/workflows by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3594](https://togithub.com/reactor/reactor-core/pull/3594) ##### :up: Dependency Upgrades - Bump io.spring.nohttp from 0.0.10 to 0.0.11 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3497](https://togithub.com/reactor/reactor-core/pull/3497) - Bump org.junit:junit-bom from 5.9.2 to 5.10.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3556](https://togithub.com/reactor/reactor-core/pull/3556) - Bump me.champeau.gradle.japicmp from 0.4.1 to 0.4.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3595](https://togithub.com/reactor/reactor-core/pull/3595) - Bump jmhVersion from 1.36 to 1.37 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3596](https://togithub.com/reactor/reactor-core/pull/3596) - Bump byteBuddyVersion from 1.14.5 to 1.14.8 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3601](https://togithub.com/reactor/reactor-core/pull/3601) - Bump com.gradle.enterprise from 3.14.1 to 3.15 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3602](https://togithub.com/reactor/reactor-core/pull/3602) - Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.12 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3476](https://togithub.com/reactor/reactor-core/pull/3476) - Bump de.undercouch.download from 5.4.0 to 5.5.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3608](https://togithub.com/reactor/reactor-core/pull/3608) - Bump com.gradle.enterprise from 3.15 to 3.15.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/reactor/reactor-core/pull/3613](https://togithub.com/reactor/reactor-core/pull/3613) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.5.10...v3.5.11 ### [`v3.5.10`](https://togithub.com/reactor/reactor-core/releases/tag/v3.5.10) [Compare Source](https://togithub.com/reactor/reactor-core/compare/v3.5.9...v3.5.10)  `Reactor Core` `3.5.10` is part of **`2022.0.11` Release Train**. #### What's Changed ##### :book: Documentation, Tests and Build - Fix return type for `Mono.tap` in javadoc by [@ajax-surovskyi-y](https://togithub.com/ajax-surovskyi-y) in [#3564](https://togithub.com/reactor/reactor-core/issues/3564) ##### :up: Dependency Upgrades - Update `Micrometer` version to `1.10.11` by [@chemicL](https://togithub.com/chemicL) in [`7f9c77e`](https://togithub.com/reactor/reactor-core/commit/7f9c77ec28dc0bdfc1eafe04062cb1195fd9b552) #### New Contributors - [@ajax-surovskyi-y](https://togithub.com/ajax-surovskyi-y) made their first contribution in [#3564](https://togithub.com/reactor/reactor-core/issues/3564) **Full Changelog**: https://github.com/reactor/reactor-core/compare/v3.5.9...v3.5.10 </details> <details> <summary>spring-projects/spring-graphql (org.springframework.graphql:spring-graphql-test)</summary> ### [`v1.2.4`](https://togithub.com/spring-projects/spring-graphql/releases/tag/v1.2.4) #### :star: New Features - Lenient parsing of SourceLocation's line and column in ResponseMapGraphQlResponse [#849](https://togithub.com/spring-projects/spring-graphql/pull/849) - Use isOmitted rather than isPresent in ValueExtractor to allow validation of null arguments [#842](https://togithub.com/spring-projects/spring-graphql/pull/842) - Allow use of custom DataLoaderRegistry instance [#836](https://togithub.com/spring-projects/spring-graphql/issues/836) - ConnectionDataFetcher should handle data wrapped with DataFetcherResult [#835](https://togithub.com/spring-projects/spring-graphql/issues/835) #### :beetle: Bug Fixes - Fix logic for hasPrevious/hasNext with keyset scrolling [#843](https://togithub.com/spring-projects/spring-graphql/issues/843) - Offset pagination with "last N before X" should not include the item at offset X [#840](https://togithub.com/spring-projects/spring-graphql/issues/840) - ControllerAdvice order is not preserved in AnnotatedControllerExceptionResolver [#830](https://togithub.com/spring-projects/spring-graphql/issues/830) - WebSocketGraphQlClient unable to reconnect after the first reconnect failure [#826](https://togithub.com/spring-projects/spring-graphql/issues/826) - AOT: No JSON Encoder error using GraphlQL client [#825](https://togithub.com/spring-projects/spring-graphql/issues/825) #### :notebook_with_decorative_cover: Documentation - Add section on code generation to the documentation [#847](https://togithub.com/spring-projects/spring-graphql/issues/847) - Use ScrollPosition.offset() to get initial scroll position [#839](https://togithub.com/spring-projects/spring-graphql/pull/839) - Add Search in All Spring Docs [#824](https://togithub.com/spring-projects/spring-graphql/pull/824) #### :hammer: Dependency Upgrades - Upgrade to Context Propagation 1.0.6 [#857](https://togithub.com/spring-projects/spring-graphql/issues/857) - Upgrade to GraphQL Java 20.7 [#852](https://togithub.com/spring-projects/spring-graphql/issues/852) - Upgrade to Micrometer 1.11.6 [#853](https://togithub.com/spring-projects/spring-graphql/issues/853) - Upgrade to Micrometer Tracing 1.1.7 [#854](https://togithub.com/spring-projects/spring-graphql/issues/854) - Upgrade to Reactor 2022.0.13 [#858](https://togithub.com/spring-projects/spring-graphql/issues/858) - Upgrade to Spring Data 2023.0.6 [#855](https://togithub.com/spring-projects/spring-graphql/issues/855) - Upgrade to Spring Framework 6.0.14 [#851](https://togithub.com/spring-projects/spring-graphql/issues/851) - Upgrade to Spring Security 6.1.5 [#856](https://togithub.com/spring-projects/spring-graphql/issues/856) #### :heart: Contributors Thank you to all the contributors who worked on this release: [@Stmated](https://togithub.com/Stmated), [@koenpunt](https://togithub.com/koenpunt), [@nilshartmann](https://togithub.com/nilshartmann), and [@rwinch](https://togithub.com/rwinch) </details> <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-websocket)</summary> ### [`v3.2.2`](https://togithub.com/spring-projects/spring-boot/releases/tag/v3.2.2) #### :lady_beetle: Bug Fixes - SslBundle implementations do not provide useful toString() results [#39167](https://togithub.com/spring-projects/spring-boot/issues/39167) - JarEntry.getComment() returns incorrect result from NestedJarFile instances [#39166](https://togithub.com/spring-projects/spring-boot/issues/39166) - Mixing PEM and JKS certificate material in server.ssl properties does not work [#39158](https://togithub.com/spring-projects/spring-boot/issues/39158) - Having AspectJ and Micrometer on the classpath is not a strong enough signal to enable support for Micrometer observation annotations [#39128](https://togithub.com/spring-projects/spring-boot/issues/39128) - Actuator endpoints with no operations that use selectors are not accessible when mapped to / [#39122](https://togithub.com/spring-projects/spring-boot/issues/39122) - Spring Boot 3.2 app that uses WebFlux, Security, and Actuator may fail to start due to a missing authentication manager [#39096](https://togithub.com/spring-projects/spring-boot/issues/39096) - management.observations.http.server.requests.name no longer has any effect [#39083](https://togithub.com/spring-projects/spring-boot/issues/39083) - spring.rabbitmq.listener.stream.auto-startup property has no effect [#39078](https://togithub.com/spring-projects/spring-boot/issues/39078) - Error mark in the log message for PatternParseException is in the wrong place [#39075](https://togithub.com/spring-projects/spring-boot/issues/39075) - Configuring server.jetty.max-connections has no effect [#39052](https://togithub.com/spring-projects/spring-boot/pull/39052) - `@ConfigurationPropertiesBinding` converters that rely on initial CharSequence to String conversion no longer work [#39051](https://togithub.com/spring-projects/spring-boot/issues/39051) - Manifest attributes cannot be resolved with the new loader implementation [#38996](https://togithub.com/spring-projects/spring-boot/issues/38996) - Throwable from logging system initialization may result in the application silently failing to start [#38963](https://togithub.com/spring-projects/spring-boot/issues/38963) - When using Jetty, idle timeout for IO operations and delayed dispatch cannot be set to less than 30000ms [#38960](https://togithub.com/spring-projects/spring-boot/issues/38960) - spring-boot-maven-plugin repackage uber jar execution fails when jar is put on WSL network drive [#38956](https://togithub.com/spring-projects/spring-boot/issues/38956) - Oracle OJDBC BOM version is flagged not for production use [#38943](https://togithub.com/spring-projects/spring-boot/issues/38943) - Connection leak when using jOOQ and spring.jooq.sql-dialect has not been set [#38924](https://togithub.com/spring-projects/spring-boot/pull/38924) - AutoConfigurationSorter does not always respect `@AutoConfigureOrder`(Ordered.LOWEST_PRECEDENCE) [#38916](https://togithub.com/spring-projects/spring-boot/issues/38916) - Containers are not started when using `@ImportTestcontainers` [#38913](https://togithub.com/spring-projects/spring-boot/issues/38913) - Even when spring.security.user.name or spring.security.user.password has been configured, user details auto-configuration still backs off when resource server is on the classpath [#38864](https://togithub.com/spring-projects/spring-boot/issues/38864) - MockRestServiceServerAutoConfiguration with RestTemplate and RestClient together throws incorrect exception [#38820](https://togithub.com/spring-projects/spring-boot/issues/38820) #### :notebook_with_decorative_cover: Documentation - Improve "Sanitize Sensitive Values" section in reference documentation [#39199](https://togithub.com/spring-projects/spring-boot/issues/39199) - Fix link to Log4j2's JDK logging adapter documentation [#39171](https://togithub.com/spring-projects/spring-boot/issues/39171) - Update CRaC support status link [#39170](https://togithub.com/spring-projects/spring-boot/pull/39170) - Remove entry for OCI starter as it is no longer maintained [#39165](https://togithub.com/spring-projects/spring-boot/issues/39165) - Update links to Micrometer docs in metrics section of reference docs [#39149](https://togithub.com/spring-projects/spring-boot/issues/39149) - Use the term "tags" in documentation consistently [#39125](https://togithub.com/spring-projects/spring-boot/pull/39125) - Correct the documentation on injecting dependencies into FailureAnalyzer implementations [#39100](https://togithub.com/spring-projects/spring-boot/issues/39100) - Polish reference documentation [#38942](https://togithub.com/spring-projects/spring-boot/pull/38942) - Document virtual threads limitations [#38883](https://togithub.com/spring-projects/spring-boot/issues/38883) #### :hammer: Dependency Upgrades - Upgrade to MySQL 8.3.0 [#39081](https://togithub.com/spring-projects/spring-boot/issues/39081) - Upgrade to Byte Buddy 1.14.11 [#39184](https://togithub.com/spring-projects/spring-boot/issues/39184) - Upgrade to Groovy 4.0.17 [#39185](https://togithub.com/spring-projects/spring-boot/issues/39185) - Upgrade to jOOQ 3.18.9 [#39186](https://togithub.com/spring-projects/spring-boot/issues/39186) - Upgrade to Kotlin 1.9.22 [#39187](https://togithub.com/spring-projects/spring-boot/issues/39187) - Upgrade to Lettuce 6.3.1.RELEASE [#39188](https://togithub.com/spring-projects/spring-boot/issues/39188) - Upgrade to MariaDB 3.3.2 [#38901](https://togithub.com/spring-projects/spring-boot/issues/38901) - Upgrade to Micrometer 1.12.2 [#38978](https://togithub.com/spring-projects/spring-boot/issues/38978) - Upgrade to Micrometer Tracing 1.2.2 [#38979](https://togithub.com/spring-projects/spring-boot/issues/38979) - Upgrade to Neo4j Java Driver 5.15.0 [#39136](https://togithub.com/spring-projects/spring-boot/issues/39136) - Upgrade to Netty 4.1.105.Final [#39189](https://togithub.com/spring-projects/spring-boot/issues/39189) - Upgrade to Pulsar 3.1.2 [#39190](https://togithub.com/spring-projects/spring-boot/issues/39190) - Upgrade to Pulsar Reactive 0.5.2 [#39191](https://togithub.com/spring-projects/spring-boot/issues/39191) - Upgrade to R2DBC MySQL 1.0.6 [#39192](https://togithub.com/spring-projects/spring-boot/issues/39192) - Upgrade to R2DBC Postgresql 1.0.4.RELEASE [#39193](https://togithub.com/spring-projects/spring-boot/issues/39193) - Upgrade to R2DBC Proxy 1.1.4.RELEASE [#39194](https://togithub.com/spring-projects/spring-boot/issues/39194) - Upgrade to Reactor Bom 2023.0.2 [#38980](https://togithub.com/spring-projects/spring-boot/issues/38980) - Upgrade to SLF4J 2.0.11 [#39195](https://togithub.com/spring-projects/spring-boot/issues/39195) - Upgrade to Spring Data Bom 2023.1.2 [#38981](https://togithub.com/spring-projects/spring-boot/issues/38981) - Upgrade to Spring Framework 6.1.3 [#38982](https://togithub.com/spring-projects/spring-boot/issues/38982) - Upgrade to Spring Pulsar 1.0.2 [#38994](https://togithub.com/spring-projects/spring-boot/issues/38994) - Upgrade to Spring WS 4.0.10 [#39130](https://togithub.com/spring-projects/spring-boot/issues/39130) - Upgrade to Tomcat 10.1.18 [#39196](https://togithub.com/spring-projects/spring-boot/issues/39196) #### :heart: Contributors Thank you to all the contributors who worked on this release: [@724thomas](https://togithub.com/724thomas), [@BenchmarkingBuffalo](https://togithub.com/BenchmarkingBuffalo), [@FBibonne](https://togithub.com/FBibonne), [@Wzy19930507](https://togithub.com/Wzy19930507), [@amparab](https://togithub.com/amparab), [@dependabot](https://togithub.com/dependabot)\[bot], [@dreis2211](https://togithub.com/dreis2211), [@okohub](https://togithub.com/okohub), [@onobc](https://togithub.com/onobc), [@sdeleuze](https://togithub.com/sdeleuze), [@skcskitano](https://togithub.com/skcskitano), and [@tobias-lippert](https://togithub.com/tobias-lippert) ### [`v3.2.1`](https://togithub.com/spring-projects/spring-boot/releases/tag/v3.2.1) #### :star: New Features - Cleanup java sources [#38877](https://togithub.com/spring-projects/spring-boot/issues/38877) #### :lady_beetle: Bug Fixes - HibernateJpaAutoConfiguration should be applied before DataSourceTransactionManagerAutoConfiguration [#38880](https://togithub.com/spring-projects/spring-boot/issues/38880) - META-INF entries are duplicated under BOOT-INF/classes causing "Conflicting persistence unit definitions" error [#38862](https://togithub.com/spring-projects/spring-boot/issues/38862) - logging.include-application-name has no effect when using log4j2 [#38847](https://togithub.com/spring-projects/spring-boot/pull/38847) - Pulsar authentication param properties cause IllegalStateException with Pulsar Client 3.1.0 [#38839](https://togithub.com/spring-projects/spring-boot/pull/38839) - Child context created with SpringApplicationBuilder runs parents runners [#38837](https://togithub.com/spring-projects/spring-boot/issues/38837) - getSigners() info is lost for signed jars when using the new loader implementation with requiresUnpack [#38833](https://togithub.com/spring-projects/spring-boot/issues/38833) - TestContainers parallel initialization doesn't work properly [#38831](https://togithub.com/spring-projects/spring-boot/issues/38831) - Zip file closed exceptions can be thrown due to StaticResourceJars closing jars from cached connections [#38770](https://togithub.com/spring-projects/spring-boot/issues/38770) - Multi-byte filenames in zip files can cause an endless loop in ZipString.hash [#38751](https://togithub.com/spring-projects/spring-boot/issues/38751) - Gradle task "bootJar" fails with "Failed to get permissions" when using Gradle 8.6-milestone-1 [#38741](https://togithub.com/spring-projects/spring-boot/issues/38741) - Custom binding converters are ignored when working with collection types [#38734](https://togithub.com/spring-projects/spring-boot/issues/38734) - WebFlux and resource server auto-configuration may fail due to null authentication manager [#38713](https://togithub.com/spring-projects/spring-boot/issues/38713) - It is unclear that Docker Compose services have not been started as one or more is already running [#38661](https://togithub.com/spring-projects/spring-boot/issues/38661) - Spring Boot jar launcher does not work in folders containing certain chars [#38660](https://togithub.com/spring-projects/spring-boot/issues/38660) - FileNotFoundException is thrown eagerly from unused SSL bundles [#38659](https://togithub.com/spring-projects/spring-boot/issues/38659) - NoUniqueBeanDefinitionFailureAnalyzer does not account for the fact that missing '-parameters' may be the cause [#38652](https://togithub.com/spring-projects/spring-boot/issues/38652) - Traces are propagated if tracing is disabled [#38641](https://togithub.com/spring-projects/spring-boot/issues/38641) - Missing registry auto-configuration for JMS listener observation support [#38613](https://togithub.com/spring-projects/spring-boot/issues/38613) - Class loading fails on an interrupted thread causing com.mongodb.event.ServerClosedEvent to fail to load when Mongo detects a cluster change [#38611](https://togithub.com/spring-projects/spring-boot/issues/38611) - Failures due to code not being compiled with '-parameters' are hard to identify [#38603](https://togithub.com/spring-projects/spring-boot/issues/38603) - System SSL certificates are not used by the Apache HTTP Client in a RestTemplate built with RestTemplateBuilder [#38600](https://togithub.com/spring-projects/spring-boot/issues/38600) - ZipFileSystem throws "java.util.zip.ZipException: read CEN tables failed" with certain nested jars [#38595](https://togithub.com/spring-projects/spring-boot/issues/38595) - Nested jar URLs cannot be split and reassembled resulting in errors with projects that use this technique (such as JobRunr) [#38592](https://togithub.com/spring-projects/spring-boot/issues/38592) - NoSuchMethodError can be thrown from Session.getCookie() due to binary incompatibilty [#38589](https://togithub.com/spring-projects/spring-boot/issues/38589) - management.metrics.tags has been deprecated without a replacement working for all metrics [#38583](https://togithub.com/spring-projects/spring-boot/issues/38583) - NegativeArraySizeException can be thrown from org.springframework.boot.loader.zip.ZipContent$Loader [#38572](https://togithub.com/spring-projects/spring-boot/issues/38572) - Migration form 3.1.5 to 3.2.0 : "Default" Tracer is not provided in test anymore [#38568](https://togithub.com/spring-projects/spring-boot/issues/38568) - TomcatWebServer stop doesn't close sockets for additional connectors [#38564](https://togithub.com/spring-projects/spring-boot/issues/38564) - Port is already in use when using `@SpringBootTest` with a separate management port and a mock web environment [#38554](https://togithub.com/spring-projects/spring-boot/issues/38554) - Keep-alive property causes processAot step to never finish [#&#82 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/federation-jvm).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ensures that proper index is used during onNext check

7638401

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>

OlegDokuka added the type/bug A general bug label Oct 6, 2023

OlegDokuka added this to the 3.5.11 milestone Oct 6, 2023

OlegDokuka requested a review from a team as a code owner October 6, 2023 10:45

chemicL requested changes Oct 9, 2023

View reviewed changes

adds proper index zeroing

a04976c

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>

chemicL approved these changes Oct 9, 2023

View reviewed changes

OlegDokuka merged commit 759375e into 3.5.x Oct 9, 2023
5 of 6 checks passed

OlegDokuka pushed a commit that referenced this pull request Oct 9, 2023

Merge #3614 into 3.6.0-RC1

c5656ab

Signed-off-by: OlegDokuka <odokuka@vmware.com>

chemicL deleted the 3.5.x-bugfix-#3525 branch April 11, 2024 12:54

This was referenced Nov 16, 2024

Update dependency io.projectreactor:reactor-core to v3.7.0 AlexRogalskiy/customiere#30

Open

fix(deps): update dependency io.projectreactor:reactor-core from 3.5.10 to 3.7.0 provenance-io/p8e-cee-api#128

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ensures that proper index is used during onNext check #3614

ensures that proper index is used during onNext check #3614

OlegDokuka commented Oct 6, 2023

chemicL Oct 9, 2023

OlegDokuka Oct 9, 2023 •

edited

Loading

OlegDokuka Oct 9, 2023

ensures that proper index is used during onNext check #3614

ensures that proper index is used during onNext check #3614

Conversation

OlegDokuka commented Oct 6, 2023

chemicL Oct 9, 2023

Choose a reason for hiding this comment

OlegDokuka Oct 9, 2023 • edited Loading

Choose a reason for hiding this comment

OlegDokuka Oct 9, 2023

Choose a reason for hiding this comment

OlegDokuka Oct 9, 2023 •

edited

Loading